Fix error message in parse_schedule #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
reviewed
Jun 10, 2025
src/shared/schedules.c
Outdated
| if (sscanf(string, "%d", &item->value) != 1) | ||
| eerrorx("%s: invalid timeout in schedule", | ||
| applet); | ||
| eerrorx("%s: invalid timeout value in schedule `%s'", |
Member
There was a problem hiding this comment.
please use two single quotes (and feel free to change the other message to it as well if it's using `')
and i think we can fold this into a single line
Contributor
Author
There was a problem hiding this comment.
Updated both messages to use '%s' style quotes. Folding into single line breaks 100 char limit and makes it longest line in file and I decided against it.
Make it consistent with the other one: in case of error report failed input. Also change quoting from `%s' to '%s'.
delamonpansie
force-pushed
the
fix-timeout-message
branch
from
c1773a9 to
3bdc645
Compare
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it consistent with the other one: in case of error report failed input.