use access syscall, remove unnecessary check, cleanup unused functions #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the exists() helper uses stat.2 unnecessarily, while calling access is simpler and does not require filling a struct stat for no reason. since this would make exists() into a wrapper that calls a single function and nothing else, let's just inline the calls to access and remove the helper.
{f,}open and setmntent will already fail if the file does not exists, no
need for an extra syscall
only one consumer, checkpath, and can easily be done directly with the access syscall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the exists() helper uses stat.2 unnecessarily, while calling access is simpler and does not require filling a struct stat for no reason.
since this would make exists() into a wrapper that calls a single function and nothing else, let's just inline the calls to access and remove the helper.
{f,}open and setmntent will already fail if the file does not exists, no need for an extra syscall
plus the removal of unused functions, and inlining is_writable, since it's only called once, and it just a wrapper for access as well