openrc-run: remove timeout from start/stop #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
approved these changes
Jul 4, 2025
Contributor
|
Thanks for the heads up on this PR in the other issue. I think we're good but I've restarted tests with 0.62.5 + #898 (sigchld block) + this PR (as rebased in https://github.com/martinetd/openrc/commits/no-timeout-start-stop/ - not a difficult conflict fix anyway) Cheers, |
4d8a5c4 added the timeout logic from svc_wait into svc_exec, with the goal of avoiding stalling the boot process should a service hang, however we failed to mention the change in NEWS, and some critical services like postgres rely on inifinite timeout for `stop()`. this logic was also sharing the `timeout` keyword from `depend()`, which is not very clean let's revert the timeout logic, and properly re-introduce it later, with effort put into making sure no issues happen. Bug: #896
navi-desu
force-pushed
the
no-timeout-start-stop
branch
from
603ca27 to
64f2557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4d8a5c4 added the timeout logic from svc_wait into svc_exec, with the goal of avoiding stalling the boot process should a service hang, however we failed to mention the change in NEWS, and some critical services like postgres rely on inifinite timeout for
stop().this logic was also sharing the
timeoutkeyword fromdepend(), which is not very cleanlet's revert the timeout logic, and properly re-introduce it later, with effort put into making sure no issues happen.
Bug: #896