checkpath: allow -W to be specified with -f/-d/-p, plus multiple formatting and structure changes #945
+146
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
force-pushed
the
checkpath-read-only
branch
2 times, most recently
from
6e7f79e to
77c3303
Compare
path is not modified in that function, and basename_c already returns a null-terminated string, so there's no need to allocate a copy
O_CLOEXEC and O_NOFOLLOW are posix for a while now, no need to check.
check for writtability after the open attempt, and still creating the file beforehand if it doesn't exist
navi-desu
force-pushed
the
checkpath-read-only
branch
from
77c3303 to
b948ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first i can't really tell if there's an issue with allowing -W with the create options
i've made the check happen before creation, as that made more sense. we need this for #936 as the mode check isn't enough, the read-only filesystem will have the right mode, thus chmod won't fail
most of the commits here are changes for checkpath unrelated to the fix proper, which happened because i was really annoyed at the code structure for checkpath.c
node: still didn't boot test this myself, we really need automated testing gaah