Skip to content

Sanitize GH App ID to catch weird nested quotes #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxmehl merged 1 commit into from
Aug 21, 2025
Merged

Sanitize GH App ID to catch weird nested quotes #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gh_org_mgr/_gh_org.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ def login(

# Decide how to login. If app set, prefer this
if self.gh_app_id and self.gh_app_private_key:
logging.debug("Logging in via app %s", self.gh_app_id)
auth = Auth.AppAuth(app_id=self.gh_app_id, private_key=self.gh_app_private_key)
gh_app_id_sanitized = str(self.gh_app_id).strip("'").strip('"')
logging.debug("Logging in via app %s", gh_app_id_sanitized)
auth = Auth.AppAuth(app_id=gh_app_id_sanitized, private_key=self.gh_app_private_key)
app = GithubIntegration(auth=auth)
try:
installation = app.get_org_installation(org=orgname)
Expand Down
Loading