Chores #91
Merged
Chores #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg
force-pushed
the
chores
branch
2 times, most recently
from
feb90ec to
3732f24
Compare
Based on maturin generated script Signed-off-by: Tristram Gräbener <[email protected]>
Excepted for the linux version, on each push Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Somehow it breaks the build without Signed-off-by: Tristram Gräbener <[email protected]>
woshilapin
reviewed
Mar 3, 2025
Contributor
There was a problem hiding this comment.
There has been questions about whether this file should be included or not in the repository. Since pyproject.toml file does describe the range of supported versions (note, the one in liblrs doesn't at the moment, maybe we want to do that instead?), .python-version could be left to the choice of the developer (and have an entry for .python-version in .gitignore?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.