Skip to content

mrd/remove nb of stops#541

Draft
Math-R wants to merge 2 commits intomrd/new-nodes-management-systemfrom
mrd/remove-nb-of-stops
Draft

mrd/remove nb of stops#541
Math-R wants to merge 2 commits intomrd/new-nodes-management-systemfrom
mrd/remove-nb-of-stops

Conversation

@Math-R
Copy link
Copy Markdown

@Math-R Math-R commented Sep 24, 2025

Description

-TrainrunSection: remove nbOfStops attribut and associated getter setter

Issues

close #535

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

-first step to transform trainrunSection.nbOfStops, in actual nodes
Copy link
Copy Markdown
Contributor

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggesting this change. I just wonder why we don't have changes arround the DataMigration.ts nor in data.service.ts

When i am loading a Netzgrafik using the numberOfStops the data must be migrated into the new schema - right?

See data.service.ts

  loadNetzgrafikDto(netzgrafikDto: NetzgrafikDto, preview = false) {
    this.netzgrafikLoadedInfoSubject.next(new NetzgrafikLoadedInfo(true, preview));

    DataMigration.migrateNetzgrafikDto(netzgrafikDto);
    
    ...
    

@Math-R
Copy link
Copy Markdown
Author

Math-R commented Sep 25, 2025

Thank you for suggesting this change. I just wonder why we don't have changes arround the DataMigration.ts nor in data.service.ts

When i am loading a Netzgrafik using the numberOfStops the data must be migrated into the new schema - right?

See data.service.ts

  loadNetzgrafikDto(netzgrafikDto: NetzgrafikDto, preview = false) {
    this.netzgrafikLoadedInfoSubject.next(new NetzgrafikLoadedInfo(true, preview));

    DataMigration.migrateNetzgrafikDto(netzgrafikDto);
    
    ...
    

Yes it's true. This change will occur at the end of the development of the new nodes management system.
@louisgreiner just report the implementation plan in this issue. (it will be translate soon).
Before permanently removing the nbOfStops property, we will modify the loading script to transform nbOfStops into an actual Node. This will allow us to not break existing projects and remain consistent.

@emersion emersion force-pushed the mrd/new-nodes-management-system branch 3 times, most recently from bf74e2a to 75f0f7a Compare January 5, 2026 13:05
@louisgreiner louisgreiner added the postponed Postponed task due to other priorities or waiting for dependencies label Jan 7, 2026
@louisgreiner louisgreiner added the area:data-model Data models and structures label Jan 29, 2026
@emersion emersion force-pushed the mrd/new-nodes-management-system branch 2 times, most recently from 396a610 to 8c6d8b5 Compare February 16, 2026 16:15
@louisgreiner louisgreiner force-pushed the mrd/new-nodes-management-system branch 5 times, most recently from d93ab6c to e051c47 Compare February 17, 2026 09:24
@louisgreiner louisgreiner force-pushed the mrd/new-nodes-management-system branch from cab5107 to 3fd9779 Compare February 26, 2026 11:01
@louisgreiner louisgreiner force-pushed the mrd/new-nodes-management-system branch 3 times, most recently from 816c943 to aa2e242 Compare March 16, 2026 10:11
@jacomyal jacomyal force-pushed the mrd/new-nodes-management-system branch from 7d911ac to 577de70 Compare March 19, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-model Data models and structures postponed Postponed task due to other priorities or waiting for dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants