Skip to content

refactor: fix null type errors #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Synar wants to merge 5 commits into
base: main
Choose a base branch
from
+117 −122
Open

refactor: fix null type errors #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57e13ec
refacto: fix null type errors in data structures
Synar Feb 4, 2026
3c005b7
refacto: streamline sortPorts in node.models
Synar Feb 4, 2026
7fb07da
refacto: fix null type errors in node.models
Synar Feb 4, 2026
d1285d1
refacto: fix null type errors in port.models
Synar Feb 4, 2026
fa676bc
refacto: fix some null type errors in node.service
Synar Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/data-structures/business.data.structures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,11 @@ export interface NodeDto {
transitions: TransitionDto[]; // all tranisitons aligned to the node
connections: ConnectionDto[]; // all connections aligned to the node

resourceId: number; // reference to the algined (resource - not yet implemented)
resourceId: number | null; // reference to the algined (resource - not yet implemented)
Copy link
Copy Markdown
Member

@emersion emersion Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use | undefined here instead of | null? For DTO specifically, it better reflects that old JSON files are missing this field.

perronkanten: number; // number of tracks where train can stop
connectionTime: number; // aka Umsteigezeit - time used to change train in minutes
trainrunCategoryHaltezeiten: TrainrunCategoryHaltezeit; // user can over-write the halte times
symmetryAxis: number; // deprecate ???
symmetryAxis: number | null; // deprecate ???
warnings: WarningDto[]; // business logic failures - warnings storage

labelIds: number[]; // list of assigned filterable labels (identifiers: See Label, LabelDto.)
Expand Down
Loading
Loading