feat: add more details to trainrun events by Synar · Pull Request #853 · OpenRailAssociation/netzgrafik-editor-frontend

Synar · 2026-02-23T14:46:18Z

Close #792

I don't completely understand numberOfStops, so it's possible I have not used the tag properly.

I have not tested the pr in osrd yet. In particular I'm quite unsure about the way to detect forward/backward direction.

The last commit add a few events that seemed missing. There's a couple that are not useful for osrd (as we deactivated the features), but should probably be emitted for other potential users that may want to use the event system too. There are a few that correspond to niche features enabled in osrd, and for which the osrd behavior is currently bugged. Finally I have not added any to visibleTrainrunsSetLabel, as the behavior already seems propagated somehow?

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

aiAdrian · 2026-02-26T13:30:30Z

I don't completely understand numberOfStops, so it's possible I have not used the tag properly.

The idea behind numberOfStops is that it serves as a placeholder for the number of stations (nodes) that are not explicitly defined. This means we don’t have to draw or specify every station where a train will stop. Instead, we can simply provide a number indicating that the train stops at n stations, without defining where they are or how long the train stays there. The stopping times and travel times are combined for that edge, or the stopping times are already integrated. This helps long‑term planners work more quickly without dealing with details that are not important at this stage of planning.

aiAdrian · 2026-02-26T13:37:23Z

The last commit add a few events that seemed missing. There's a couple that are not useful for osrd (as we deactivated the features), but should probably be emitted for other potential users that may want to use the event system too. There are a few that correspond to niche features enabled in osrd, and for which the osrd behavior is currently bugged. Finally I have not added any to visibleTrainrunsSetLabel, as the behavior already seems propagated somehow?

Could you share an overview of what OSRD uses? It might be helpful to have a short document with links in the technical documentation folder. I think it would be important to provide an overview of the components OSRD relies on, and which application uses which layer or interface (API).

API documentation would be really helpful -> https://github.com/OpenRailAssociation/netzgrafik-editor-frontend/tree/main/documentation/technical (if the documentation is somewhere else -> please share / link it)

louisgreiner · 2026-02-26T16:58:03Z

As OSRD is directly listening to every "operation" events, you can consider that OSRD reacts to every operation.emit you can find in the code of NGE. See our listener.

Such documentation would be difficult to provide, and more important, difficult to maintain. For instance, I tried to note everything here, a long time ago, but I fear that this is not up to date anymore.

Synar · 2026-02-26T17:37:05Z

To add some information to Louis's answer, we have only disabled a couple of actions in the fork. For example, I think the action of turning a node into a non node stop or vice versa is disabled in osrd currently (as osrd lack a model for non node stop). We have also disabled the file import (as it's done in osrd interface instead), and we have disabled the save filter actions as we don't store them. I may forget a thing or two, but the differences are intentionally kept minimal. Everything else we use!

Synar · 2026-02-26T17:37:41Z

I don't completely understand numberOfStops, so it's possible I have not used the tag properly.

The idea behind numberOfStops is that it serves as a placeholder for the number of stations (nodes) that are not explicitly defined. This means we don’t have to draw or specify every station where a train will stop. Instead, we can simply provide a number indicating that the train stops at n stations, without defining where they are or how long the train stays there. The stopping times and travel times are combined for that edge, or the stopping times are already integrated. This helps long‑term planners work more quickly without dealing with details that are not important at this stage of planning.

Thanks for the explanation!

louisgreiner · 2026-02-26T17:41:01Z

Yep, if you are curious, here are all the things we do differently when we use NGE for OSRD: main...osrd-project:netzgrafik-editor-frontend:standalone

emersion · 2026-03-17T15:51:33Z

src/app/services/data/trainrun.service.ts

  }

-  updateDirection(trainrun: Trainrun, direction: Direction) {
+  updateDirection(trainrun: Trainrun, direction: Direction, isTrainInverted?: boolean) {


Could we pass "forward" | "backward" directly as a function argument to avoid the boolean?

emersion · 2026-03-17T15:54:16Z

src/app/services/data/node.service.ts

-      new TrainrunOperation(OperationType.update, trainrunSections.trainrunSection1.getTrainrun()),
+      new TrainrunUpdateOperation(trainrunSections.trainrunSection1.getTrainrun(), [
+        "times",
+        "numberOfStops",


I don't think numberOfStops changes when toggling non-stop?

I will trust you on this.

I am relatively confident about the other tags, but for numberOfStops I only have a general idea of its meaning. So I added it to anything that seemed to touch stops (better to update for nothing than miss an update). But yeah, if you do know which functions actually touch it, that's better =p

src/app/services/data/trainrun.service.ts

emersion · 2026-03-17T16:03:45Z

src/app/services/data/trainrun.service.ts

    this.trainrunsUpdated();
+    this.operation.emit(
+      new TrainrunUpdateOperation(trainrun1, ["nodes", "times", "numberOfStops"]),
+    );


Aren't we missing a TrainrunDeleteOperation here?

Hmm I don't think so, there is a call to this.deleteTrainrun earlier which I believe already emits the event

emersion · 2026-03-17T16:08:15Z

src/app/services/data/trainrunsection.service.ts

    if (this.getTrainrunSections().length) {
      this.operation.emit(
-        new TrainrunOperation(OperationType.update, trainrunSection.getTrainrun()),
+        new TrainrunUpdateOperation(trainrunSection.getTrainrun(), [


Hm, do you recall why we fire a TrainrunUpdateOperation here?

I honestly don't remember :/

My understanding is as follow:

either we deleted the last section of the trainrun, in which case the deletion of the section will trigger the deletion of the trainrun which will fire a delete event

or we still have some sections left in the trainrun. In that case we need to update it as we have changed its path, and I don't believe any update event is fired prior.

aiAdrian

For me fine - but i can't test it ! @louisgreiner please give final OK !

Synar added 5 commits February 10, 2026 11:24

refactor: split TrainrunOperation class by crud type

32f422c

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

feat: add optional duplicated id to TrainrunCreateOperation event

09ad4a7

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

feat: add tags for modified fields to TrainrunUpdateOperation event

40b2ee1

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

feat: add optional oneWayDirection to TrainrunUpdateOperation event

8b9d6f6

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

feat: add missing TrainrunUpdateOperation events

8e8cb5b

Signed-off-by: Alice K. <alice.khoudli@gmail.com>

Synar requested a review from aiAdrian as a code owner February 23, 2026 14:46

Synar requested review from emersion and louisgreiner February 23, 2026 14:46

Synar mentioned this pull request Feb 27, 2026

front: improve nge events OpenRailAssociation/osrd#15467

Draft

emersion reviewed Mar 17, 2026

View reviewed changes

src/app/services/data/trainrun.service.ts Show resolved Hide resolved

emersion reviewed Mar 17, 2026

View reviewed changes

aiAdrian approved these changes Mar 28, 2026

View reviewed changes

Conversation

Synar commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aiAdrian commented Feb 26, 2026

Uh oh!

aiAdrian commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

louisgreiner commented Feb 26, 2026

Uh oh!

Synar commented Feb 26, 2026

Uh oh!

Synar commented Feb 26, 2026

Uh oh!

louisgreiner commented Feb 26, 2026

Uh oh!

emersion Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Synar Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

emersion Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Synar Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emersion Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Synar Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

emersion Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

louisgreiner Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Synar Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aiAdrian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Synar commented Feb 23, 2026 •

edited

Loading

aiAdrian commented Feb 26, 2026 •

edited

Loading

emersion Mar 17, 2026 •

edited

Loading

Synar Mar 19, 2026 •

edited

Loading

Synar Mar 19, 2026 •

edited

Loading