Conversation
mxmehl
left a comment
There was a problem hiding this comment.
SSH key added. Please fix the preview subdir before running the next workflow.
1839ae3 to
53cfe24
Compare
|
Many thanks! It seems like we're failing SSH authentication, do you think it's something you can fix on your side @mxmehl? |
|
Oh sorry, that was my fault. SSH key is now working, @emersion. But the deployment does not work. As far as I can see, the workflow doesn't have the necessary permissions: permissions:
contents: read
# pull-requests: write # for sticky_comment_enabled, which you don't use
deployments: write # for gh_deployment |
53cfe24 to
3b85150
Compare
|
Aha, yes, seems like we've been investigating in parallel :P I've kept |
The default index.html contains this tag:
<base href="/" />
This makes it so all resources are loaded relative to the root of
the Web server. This is required for proper navigation when NGE is
deployed with its backend. However, this prevents NGE to be
deployed in a sub-directory in standalone mode.
Create a separate index.html for use in standalone mode without the
<base> tag.
Unfortunately the filename needs to be exactly "index.html", otherwise
it won't have the correct name in the build directory. We have no
choice but to create a separate directory just for that file.
Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
3b85150 to
f992ed9
Compare
|
Perfect, this now works as expected! I've added a small additional commit to make it so NGE can be deployed in a subdir (see commit description for more details). |
louisgreiner
left a comment
There was a problem hiding this comment.
This works so great, awesome!
|
I don't understand what this PR / change will do -> please give more information (call?) |
|
Fine from the technical side for me. I am open to support you with hosting the prod instance on an OpenRail webserver as well, but that'd probably best handled in a separate PR. |
@mxmehl: would it be possible to add a new SSH key for NGE? I don't think we have a domain name for NGE yet though…