front: fix deletion of empty pathStepItem in ItineraryModal#16009
Open
RomainValls wants to merge 1 commit intodevfrom
Open
front: fix deletion of empty pathStepItem in ItineraryModal#16009RomainValls wants to merge 1 commit intodevfrom
RomainValls wants to merge 1 commit intodevfrom
Conversation
Signed-off-by: romainvalls <romain.valls95@gmail.com>
| resetOpSuggestions(); | ||
|
|
||
| if (activeStepId === stepId) setActiveStepId(''); | ||
| if (pathSteps.length === 2) return; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (pathSteps.length === 2) return; |
You don't need this early return. You only call this function when hasSingleStepWithTrailing is false, meaning you'll have at least 3 pathSteps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15949
reminder for the review: there should always be at least two lines of pathStepItem : the first and the trailing path step.