Open
Conversation
* Hight Priority fixes - AI review ReapErase document in wrong place - causes confusion, as is not part of Quick Docs. The Riak Theory Guide is no longer work in progress. There may be further additions, but nothing planned - there's no TODO. Avoid confusion caused by referring to reactive management in the proactive reconciliation section. Describe proactive reconciliation first, be clearer reactive management is providing context. * Clarify new words
* Update README.md Although README is not part of QuickDocs, it should still have a consistent message aligned with Riak 3.4. * Fix "a number of" issues Saying "a number of" is flagged by AI as being vague. Sometimes vagueness was deliberate, to avoid counting and listing everything in a way that would be brittle to future changes. However, by rule, I think "a number of" can be considered a sign of lazy writing. So each instance is addressed. * Some or several other examples of vagueness * Add some information on deprecation of write once path * Re-review edits to change * Another sweep with spellcheck/grammarcheck * Clarification and Typo fix
Add spell-checker on PR, and fix the spelling errors it has discovered. Requires an extensive, bespoke wordlist. This has been categorised to try and ease management for the future.
Add link checking GHA, and fix the broken links it found
* Don't jitter by more than the available time slice The jitter randomises spacing, but shouldn't cause out of order scheduling. * Update src/riak_kv_ttaaefs_manager.erl Co-authored-by: Thomas Arts <thomas.arts@quviq.com> --------- Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
* Count last active status changes, but on same timestamp
* Flatten Suspended list before checking max
Also add an eqc profile to allow for `rebar3 as eqc do shell`, then:
eqc:module({numtests, 5000}, replrtq_snk_eqc).
* Pause monitor to wait for fetches
900 microseconds is considered to be reasonable delay in drop_slack function - so 1ms should be OK for pause.
* Extend SLACK and catch divide by 0
Passes 50K tests
* Switch sleep to yield - post review
* Add tracking of configurable VM limits to operations checklist * Add proc (for vm_proc_percent) * Change words to reflect differences between process monitoring and other stats The ets limit is no longer a hard limit. the atom count and port count growing is probably an indication of an issue - i.e. unlike the process count it should not need to be increased with scale.
An example of the use of dict() missed when updating for vi metadata
wday-contrib 2325
…nt the `ulimit` command via a non-POSIX shell.
* Adds references to where system limits are configured. * Adds comments in the source explaining limit thresholds. * Adjusts some thresholds to [hopefully] be more realistic.
* riak admin vnode-status, clique-conformant now printing a JSON object * vnode-status: jsonify partition idx's as binaries to work with json parsers that may choke on very large ints * vnode-status: jsonify all other backend statuses * vnode-status: avoid doing rpc to self * vnode-status: don't forget multi_prefix backend * vnode-status: -p option * vnode-status: repackage bitcask status tuples * mochijson2 is deprecated, don't use it in new code * vnode-status: provide defaults for eleveldb stats which are not available on fresh start * vnode-status: missing clause in map_from_deep_list * mention `riak admin vnode-status` in OperationsAndTroubleshooting section --------- Co-authored-by: Andriy Zavada <andriy.zavada@tiot.jp>
* Clarify differences for starting Riak Based on how the release was made. * Add stdout * Update following review
* Add `queue_raw_keys` and `queue_raw_terms` It may be possible to require a large `raw_keys` or `raw_terms` query that may require excessive amounts of memory to accumulate. In this case, the results can now be queued (on disk), and the fetched in batches from the queue (potentially by multiple processes). This requires two new accumulation_options `queue_raw_keys`/`queue_raw_terms`. The Queue HTTP API now supports a `GET` as well as a `POST` so that results can be fetched, (async via `GET` following a `POST`). * Add clunky urlsafe b64 decode for OTP 24 And confirm it has the same outcome as OTP 26. Also check that the pid() is a child of the supervisor - otherwise may crash a new process started with the same pid() if it doesn't understand the call message. This requires the querybuffer processes to be supervised. * Add QuickDocs changes Change some references, in the hope of clarifying the meaning. * Add new words * Change of get_test_dir from error_logger change * Use 410 Gone if queue not present More valid from a HTTP perspective, and we generally expect this to be a client error not a server error * Updates following review * Handle a decoded queue reference in the wrong format * Change unexpected 400 to a client error
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - further PRs due