Add vnode_object_cache without property re-fetching#66
Draft
martinsumner wants to merge 2 commits intoopenriak-3.4from
Draft
Add vnode_object_cache without property re-fetching#66martinsumner wants to merge 2 commits intoopenriak-3.4from
martinsumner wants to merge 2 commits intoopenriak-3.4from
Conversation
This adds a vnode_object_cache to replace the (assume unused) metadata cache. to make this useful it is enabled as a bucket property, so it can be targeted at specific buckets which require frequent updates and have small object sizes (i.e. counters). As part of the introduction, to improve performance, repeated requests to retrieve the bucket properties have been removed from the PUT flow to allow for the properties to be fetched once at the start of the PUT (and even passed as an option from the FSM),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a vnode_object_cache to replace the (assume unused) metadata cache. to make this useful it is enabled as a bucket property, so it can be targeted at specific buckets which require frequent updates and have small object sizes (i.e. counters).
As part of the introduction, to improve performance, repeated requests to retrieve the bucket properties have been removed from the PUT flow to allow for the properties to be fetched once at the start of the PUT (and even passed as an option from the FSM),