Conversation
GitOrigin-RevId: c0eba1d9fad6b78c625ce4c192855bd63d87d58c
GitOrigin-RevId: ea69f116f192b69d15177330279affe214c1d552
GitOrigin-RevId: 0a99ae67ae45cc49166a123a70c5209fa4ede80b
GitOrigin-RevId: aae3911dcc666a818f9b58f3ca47a25de252c6da
…pybara import The Copybara import brought gen.lock referencing generation refs that don't exist in this repo (they exist in the monorepo source). Speakeasy's 3-way merge failed on src/lib/config.ts. Resolution: 1. Resolved config.ts conflict by keeping the current (hooks-enabled) version 2. Re-ran speakeasy run --skip-versioning to regenerate gen.lock with valid refs The new generation ref (62917ff7-df36-438c-bde9-649eb4ad6258) has been pushed to origin and gen.lock now tracks it correctly.
GitOrigin-RevId: d53d72d70eaca3ae2dd3020ae22343b520f1793a
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Preserve custom exports in src/index.ts (tool types, Claude message types, streaming helpers) - Preserve SDKHooks integration in src/lib/config.ts - Run speakeasy run --skip-versioning to reconcile generation tracking Resolves CI failure on PR #140 (dev→main sync)
There was a problem hiding this comment.
Pull request overview
This PR syncs the latest SDK state from the monorepo to the main branch, replacing a stale PR #111 that had failing CI. The changes are generated by Speakeasy v1.680.0 from an updated OpenAPI specification.
Key Changes:
- Added new models for percentile-based latency and throughput preferences (
PreferredMinThroughput,PreferredMaxLatency,PercentileThroughputCutoffs,PercentileLatencyCutoffs,PercentileStats) - Added
ResponsesOutputModalityenum for output modality types - Added
azure-openai-responses-v1to reasoning format enums - Updated provider names (added Inceptron, Seed, Upstage; removed GoPomelo, Targon)
- Updated OpenAPI specifications and Speakeasy workflow/generation lock files
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/models/responsesoutputmodality.ts |
New enum for response output modalities (text, image) |
src/models/preferredminthroughput.ts |
New union type for minimum throughput preferences |
src/models/preferredmaxlatency.ts |
New union type for maximum latency preferences |
src/models/percentilethroughputcutoffs.ts |
New type for percentile-specific throughput cutoffs |
src/models/percentilestats.ts |
New type for percentile statistics (p50, p75, p90, p99) |
src/models/percentilelatencycutoffs.ts |
New type for percentile-specific latency cutoffs |
src/models/index.ts |
Added exports for new model types |
docs/models/*.md |
Added documentation for all new types |
.speakeasy/out.openapi.yaml |
Updated OpenAPI spec with new schemas and enum values |
.speakeasy/in.openapi.yaml |
Updated input OpenAPI spec with new schemas |
.speakeasy/gen.lock |
Updated generation checksums and tracked files |
.speakeasy/workflow.lock |
Updated source revision and blob digests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export type PreferredMinThroughput = number | PercentileThroughputCutoffs | any; | ||
|
|
||
| /** @internal */ | ||
| export type PreferredMinThroughput$Outbound = | ||
| | number | ||
| | PercentileThroughputCutoffs$Outbound | ||
| | any; | ||
|
|
||
| /** @internal */ | ||
| export const PreferredMinThroughput$outboundSchema: z.ZodType< | ||
| PreferredMinThroughput$Outbound, | ||
| PreferredMinThroughput | ||
| > = z.union([z.number(), PercentileThroughputCutoffs$outboundSchema, z.any()]); |
There was a problem hiding this comment.
The type union includes | any which defeats TypeScript's type safety. This appears to be how Speakeasy generates types for nullable anyOf schemas, but it would be better to use | null | undefined instead of | any. The any type allows any value to be passed without type checking, which undermines the type safety benefits of TypeScript.
| export type PreferredMinThroughput = number | PercentileThroughputCutoffs | any; | |
| /** @internal */ | |
| export type PreferredMinThroughput$Outbound = | |
| | number | |
| | PercentileThroughputCutoffs$Outbound | |
| | any; | |
| /** @internal */ | |
| export const PreferredMinThroughput$outboundSchema: z.ZodType< | |
| PreferredMinThroughput$Outbound, | |
| PreferredMinThroughput | |
| > = z.union([z.number(), PercentileThroughputCutoffs$outboundSchema, z.any()]); | |
| export type PreferredMinThroughput = | |
| | number | |
| | PercentileThroughputCutoffs | |
| | null | |
| | undefined; | |
| /** @internal */ | |
| export type PreferredMinThroughput$Outbound = | |
| | number | |
| | PercentileThroughputCutoffs$Outbound | |
| | null | |
| | undefined; | |
| /** @internal */ | |
| export const PreferredMinThroughput$outboundSchema: z.ZodType< | |
| PreferredMinThroughput$Outbound, | |
| PreferredMinThroughput | |
| > = z | |
| .union([ | |
| z.number(), | |
| PercentileThroughputCutoffs$outboundSchema, | |
| z.null(), | |
| ]) | |
| .optional(); |
| export type PreferredMaxLatency = number | PercentileLatencyCutoffs | any; | ||
|
|
||
| /** @internal */ | ||
| export type PreferredMaxLatency$Outbound = | ||
| | number | ||
| | PercentileLatencyCutoffs$Outbound | ||
| | any; | ||
|
|
||
| /** @internal */ | ||
| export const PreferredMaxLatency$outboundSchema: z.ZodType< | ||
| PreferredMaxLatency$Outbound, | ||
| PreferredMaxLatency | ||
| > = z.union([z.number(), PercentileLatencyCutoffs$outboundSchema, z.any()]); |
There was a problem hiding this comment.
The type union includes | any which defeats TypeScript's type safety. This appears to be how Speakeasy generates types for nullable anyOf schemas, but it would be better to use | null | undefined instead of | any. The any type allows any value to be passed without type checking, which undermines the type safety benefits of TypeScript.
| export type PreferredMaxLatency = number | PercentileLatencyCutoffs | any; | |
| /** @internal */ | |
| export type PreferredMaxLatency$Outbound = | |
| | number | |
| | PercentileLatencyCutoffs$Outbound | |
| | any; | |
| /** @internal */ | |
| export const PreferredMaxLatency$outboundSchema: z.ZodType< | |
| PreferredMaxLatency$Outbound, | |
| PreferredMaxLatency | |
| > = z.union([z.number(), PercentileLatencyCutoffs$outboundSchema, z.any()]); | |
| export type PreferredMaxLatency = | |
| | number | |
| | PercentileLatencyCutoffs | |
| | null | |
| | undefined; | |
| /** @internal */ | |
| export type PreferredMaxLatency$Outbound = | |
| | number | |
| | PercentileLatencyCutoffs$Outbound | |
| | null | |
| | undefined; | |
| /** @internal */ | |
| export const PreferredMaxLatency$outboundSchema: z.ZodType< | |
| PreferredMaxLatency$Outbound, | |
| PreferredMaxLatency | |
| > = z.union([ | |
| z.number(), | |
| PercentileLatencyCutoffs$outboundSchema, | |
| z.null(), | |
| z.undefined(), | |
| ]); |
|
Closing this PR as we're resetting the dev branch to main for a clean state. |
Summary
Fresh export from monorepo. Replaces stale PR #111 (closed after 3+ weeks).
Changes
Syncs latest SDK state from monorepo to main branch.
Notes
Related