Fix unsigned difference expression compared to zero #2299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Jan 12, 2026
|
|
||
| const size_t fix_text_len = strlen(fix_text); | ||
| int start_offset = 0; | ||
| size_t start_offset = 0; |
Member
There was a problem hiding this comment.
I think that there is a problem that the start_offset parameter of the oscap_pcre_exec function is defined as int in the function declaration.
PCRE2 is expecting uint32_t, not int
Should be size_t not int, per the types on pcre2_match_8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/OpenSCAP/openscap/security/code-scanning/1414