Skip to content

Commit 9cc1e43

Browse files
committed
Rubocop does not want us to use ==0
Addressing rubocop comments like: C: Use **.zero? instead of ** == 0. I think rubocop developers could be employed in Brussels.
1 parent 9717e2d commit 9cc1e43

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

lib/openscap/ds/arf.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def test_result(id = nil)
4444

4545
def test_result=(tr)
4646
source = tr.source
47-
OpenSCAP.raise! unless OpenSCAP.ds_rds_session_replace_report_with_source(@session, source.raw) == 0
47+
OpenSCAP.raise! unless OpenSCAP.ds_rds_session_replace_report_with_source(@session, source.raw).zero?
4848
end
4949

5050
def report_request(id = nil)

lib/openscap/source.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def validate!
4343
end
4444

4545
def save(filepath = nil)
46-
OpenSCAP.raise! unless OpenSCAP.oscap_source_save_as(@raw, filepath) == 0
46+
OpenSCAP.raise! unless OpenSCAP.oscap_source_save_as(@raw, filepath).zero?
4747
end
4848

4949
def destroy

lib/openscap/xccdf/policy_model.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def destroy
4242

4343
def policies_init
4444
policies = {}
45-
OpenSCAP.raise! unless OpenSCAP.xccdf_policy_model_build_all_useful_policies(raw) == 0
45+
OpenSCAP.raise! unless OpenSCAP.xccdf_policy_model_build_all_useful_policies(raw).zero?
4646
polit = OpenSCAP.xccdf_policy_model_get_policies raw
4747
while OpenSCAP.xccdf_policy_iterator_has_more polit
4848
policy_p = OpenSCAP.xccdf_policy_iterator_next polit

lib/openscap/xccdf/session.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def load(opts = {})
3333
OpenSCAP.xccdf_session_set_component_id(@s, o[:component_id])
3434
end
3535
OpenSCAP.raise! unless OpenSCAP.xccdf_session_load(@s).zero?
36-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_load_check_engine_plugins(@s) == 0
36+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_load_check_engine_plugins(@s).zero?
3737
end
3838

3939
def profile=(p)
@@ -48,7 +48,7 @@ def evaluate
4848
end
4949

5050
def remediate
51-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_remediate(@s) == 0
51+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_remediate(@s).zero?
5252
end
5353

5454
def export_results(opts = {})
@@ -72,10 +72,10 @@ def destroy
7272
private
7373

7474
def export
75-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_oval(@s) == 0
76-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_check_engine_plugins(@s) == 0
77-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_xccdf(@s) == 0
78-
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_arf(@s) == 0
75+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_oval(@s).zero?
76+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_check_engine_plugins(@s).zero?
77+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_xccdf(@s).zero?
78+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_export_arf(@s).zero?
7979
end
8080

8181
def export_targets(opts = {})

lib/openscap/xccdf/testresult.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def score
4949
def score!(benchmark)
5050
# recalculate the scores in the scope of given benchmark
5151
@score = nil
52-
OpenSCAP.raise! unless OpenSCAP.xccdf_result_recalculate_scores(@raw, benchmark.raw) == 0
52+
OpenSCAP.raise! unless OpenSCAP.xccdf_result_recalculate_scores(@raw, benchmark.raw).zero?
5353
score
5454
end
5555

0 commit comments

Comments
 (0)