Skip to content

Defer redis connection until first use (avoid sockets stuck in CLOSE_WAIT) #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Defer redis connection until first use (avoid sockets stuck in CLOSE_WAIT) #3618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions modules/cachedb_redis/cachedb_redis_dbase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,12 +446,15 @@ redis_con* redis_new_connection(struct cachedb_id* id)
con->ref = 1;
con->flags |= multi_hosts; /* if the case */

/* if doing failover Redises, only connect the 1st one for now! */
if (!cons && redis_connect(con) < 0) {
LM_ERR("failed to connect to DB\n");
if (shutdown_on_error)
goto out_err;
}
/* We don't actually connect just yet. The connection will be made when
it is first used.
If we connect to redis now then any sockets that won't get used will
get stuck in CLOSE_WAIT forever if the redis server disconnects (e.g.
when it restarts).
By deferring connection until first use, we expect that any sockets
that get disconnected will eventually get reconnected, because they
wouldn't have got connected in the first place if they weren't
in use. */

_add_last(con, cons, next_con);
}
Expand Down
Loading