Merged
Conversation
Member
Author
|
Once OpenSLO/OpenSLO#313 is merged, I will create an RC version and use that instead of the commit hash. |
BSski
approved these changes
Dec 17, 2024
…switch-to-openslo-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertsubcommand. It was not maintained anymore (for the past 2 years+) and we agreed last year to encourage developing custom converters outside ofosloproject.pkg. The utlities which were exposed there can now be replaced with OpenSLO SDK.If there are functions missing from the SDK, we expect them to be implemented in the SDK,
oslowill no longer be a Go library.pkgtointernal, removing bloated packages.fmtsubcommand.Out of scope
After this PR is merged, but BEFORE a new
osloversion is released we need to cover thebatstest cases better.