Merge pull request #484 from OpenSPP/improve-cycle-date-validations

Improved the validations of the dates in cycle

Author: gonzalesedwin1123

spp_programs/models/cycle.py

@@ -1,6 +1,7 @@
 # Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 
-from odoo import fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class G2PCycle(models.Model):
@@ -49,3 +50,11 @@ def get_entitlements(
         if count:
             return self.env["g2p.cycle.membership"].search_count(domain, limit=limit)
         return self.env[entitlement_model].search(domain, offset=offset, limit=limit, order=order)
+
+    @api.constrains("start_date", "end_date")
+    def _check_dates(self):
+        for record in self:
+            if record.start_date and record.start_date < fields.Date.today():
+                raise ValidationError(_('The "Start Date" cannot be earlier than today.'))
+            if record.end_date and record.start_date and record.end_date < record.start_date:
+                raise ValidationError(_('The "End Date" cannot be earlier than the "Start Date".'))

spp_programs/tests/__init__.py

@@ -4,3 +4,4 @@
 from . import test_programs
 from . import test_registrant
 from . import test_stock_rule
+from . import test_cycle

spp_programs/tests/test_cycle.py

@@ -0,0 +1,23 @@
+from freezegun import freeze_time
+
+from odoo.exceptions import ValidationError
+
+from .common import Common
+
+
+@freeze_time("2024-07-19")
+class TestCycle(Common):
+    def test_check_dates_constrains(self):
+        with self.assertRaisesRegex(ValidationError, 'The "End Date" cannot be earlier than the "Start Date".'):
+            self.cycle.write(
+                {
+                    "end_date": "2024-07-18",
+                }
+            )
+
+        with self.assertRaisesRegex(ValidationError, 'The "Start Date" cannot be earlier than today.'):
+            self.cycle.write(
+                {
+                    "start_date": "2024-07-18",
+                }
+            )