Skip to content

Comments

Add Widgets for Stages#11

Merged
OpenSauce merged 2 commits intomainfrom
add-widgets
Jun 1, 2025
Merged

Add Widgets for Stages#11
OpenSauce merged 2 commits intomainfrom
add-widgets

Conversation

@OpenSauce
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 31, 2025 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds user interface widgets for each simulation stage and implements Display on enum types to improve pick list labels.

  • Derive PartialEq and add Display implementations for ToneStackModel, PowerAmpType, FilterType, and ClipperType.
  • Introduce new GUI widgets under src/gui/widgets/ for tone stack, preamp, power amp, filter, and compressor stages.
  • Expose a widgets module in src/gui/mod.rs.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/sim/stages/tonestack.rs Added PartialEq derive and Display impl for ToneStackModel.
src/sim/stages/poweramp.rs Added PartialEq derive and Display impl for PowerAmpType.
src/sim/stages/filter.rs Added PartialEq derive and Display impl for FilterType.
src/sim/stages/clipper.rs Added PartialEq derive and Display impl for ClipperType.
src/gui/widgets/tonestack.rs New widget for tone stack configuration.
src/gui/widgets/preamp.rs New widget for preamp (clipper) configuration.
src/gui/widgets/poweramp.rs New widget for power amp configuration.
src/gui/widgets/filter.rs New widget for filter configuration.
src/gui/widgets/compressor.rs New widget for compressor configuration.
src/gui/widgets/mod.rs Consolidated widget factory functions.
src/gui/mod.rs Exposed the widgets module.
Comments suppressed due to low confidence (1)

src/gui/widgets/poweramp.rs:15

  • [nitpick] Rename amp_types to poweramp_types or power_amp_types for clarity and consistency with the widget’s purpose and other modules.
let amp_types = vec![

@OpenSauce OpenSauce requested a review from Copilot June 1, 2025 09:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new widget implementations for visualizing and interacting with various audio stages in the simulation. Key changes include:

  • Updates to simulation stage enums (ToneStack, PowerAmp, Filter, and Clipper) to derive PartialEq and provide Display implementations.
  • Addition of new GUI widget modules for ToneStack, Preamp, PowerAmp, Filter, and Compressor.
  • Integration of these widgets into the GUI module to support stage removal and parameter control.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/sim/stages/tonestack.rs Added PartialEq derivation and Display impl for ToneStackModel
src/sim/stages/poweramp.rs Added PartialEq derivation and Display impl for PowerAmpType
src/sim/stages/filter.rs Added PartialEq derivation and Display impl for FilterType
src/sim/stages/clipper.rs Added PartialEq derivation and Display impl for ClipperType
src/gui/widgets/tonestack.rs Added new widget for Tone Stack control
src/gui/widgets/preamp.rs Added new widget for Preamp control
src/gui/widgets/poweramp.rs Added new widget for Power Amp control
src/gui/widgets/filter.rs Added new widget for Filter control
src/gui/widgets/compressor.rs Added new widget for Compressor control
src/gui/widgets/mod.rs Updated module exports to include new widget modules
src/gui/mod.rs Integrated widget module into the GUI module

@OpenSauce OpenSauce merged commit 072d9bd into main Jun 1, 2025
2 checks passed
@OpenSauce OpenSauce deleted the add-widgets branch June 1, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant