Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds user interface widgets for each simulation stage and implements Display on enum types to improve pick list labels.
- Derive
PartialEqand addDisplayimplementations forToneStackModel,PowerAmpType,FilterType, andClipperType. - Introduce new GUI widgets under
src/gui/widgets/for tone stack, preamp, power amp, filter, and compressor stages. - Expose a
widgetsmodule insrc/gui/mod.rs.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sim/stages/tonestack.rs | Added PartialEq derive and Display impl for ToneStackModel. |
| src/sim/stages/poweramp.rs | Added PartialEq derive and Display impl for PowerAmpType. |
| src/sim/stages/filter.rs | Added PartialEq derive and Display impl for FilterType. |
| src/sim/stages/clipper.rs | Added PartialEq derive and Display impl for ClipperType. |
| src/gui/widgets/tonestack.rs | New widget for tone stack configuration. |
| src/gui/widgets/preamp.rs | New widget for preamp (clipper) configuration. |
| src/gui/widgets/poweramp.rs | New widget for power amp configuration. |
| src/gui/widgets/filter.rs | New widget for filter configuration. |
| src/gui/widgets/compressor.rs | New widget for compressor configuration. |
| src/gui/widgets/mod.rs | Consolidated widget factory functions. |
| src/gui/mod.rs | Exposed the widgets module. |
Comments suppressed due to low confidence (1)
src/gui/widgets/poweramp.rs:15
- [nitpick] Rename
amp_typestopoweramp_typesorpower_amp_typesfor clarity and consistency with the widget’s purpose and other modules.
let amp_types = vec![
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new widget implementations for visualizing and interacting with various audio stages in the simulation. Key changes include:
- Updates to simulation stage enums (ToneStack, PowerAmp, Filter, and Clipper) to derive PartialEq and provide Display implementations.
- Addition of new GUI widget modules for ToneStack, Preamp, PowerAmp, Filter, and Compressor.
- Integration of these widgets into the GUI module to support stage removal and parameter control.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/sim/stages/tonestack.rs | Added PartialEq derivation and Display impl for ToneStackModel |
| src/sim/stages/poweramp.rs | Added PartialEq derivation and Display impl for PowerAmpType |
| src/sim/stages/filter.rs | Added PartialEq derivation and Display impl for FilterType |
| src/sim/stages/clipper.rs | Added PartialEq derivation and Display impl for ClipperType |
| src/gui/widgets/tonestack.rs | Added new widget for Tone Stack control |
| src/gui/widgets/preamp.rs | Added new widget for Preamp control |
| src/gui/widgets/poweramp.rs | Added new widget for Power Amp control |
| src/gui/widgets/filter.rs | Added new widget for Filter control |
| src/gui/widgets/compressor.rs | Added new widget for Compressor control |
| src/gui/widgets/mod.rs | Updated module exports to include new widget modules |
| src/gui/mod.rs | Integrated widget module into the GUI module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.