Skip to content

Comments

Switch stages up and down#13

Merged
OpenSauce merged 2 commits intomainfrom
swap-stages
Jun 7, 2025
Merged

Switch stages up and down#13
OpenSauce merged 2 commits intomainfrom
swap-stages

Conversation

@OpenSauce
Copy link
Owner

Must be a better way of doing this but kept hitting issues

Copilot AI review requested due to automatic review settings June 7, 2025 19:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces stage reordering functionality by adding move-up and move-down buttons to various stage widgets. Key changes include the addition of new messages (MoveStageUp and MoveStageDown), updating all stage widget functions to accept a total_stages parameter, and refactoring the header UI elements to use the new icon_button.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/gui/widgets/tonestack.rs Added up/down buttons to reorder ToneStack stages and updated header text.
src/gui/widgets/preamp.rs Added up/down buttons for Preamp stages with total stage count parameter.
src/gui/widgets/poweramp.rs Introduced stage reordering and adjusted header alignment styling.
src/gui/widgets/filter.rs Updated Filter widget with move-stage buttons and new total_stages parameter.
src/gui/widgets/compressor.rs Integrated move-stage buttons into Compressor widget, similar to others.
src/gui/widgets/mod.rs Added a reusable icon_button helper and ICONS_FONT constant.
src/gui/amp.rs Added handling for MoveStageUp and MoveStageDown messages in the stage update logic.
Comments suppressed due to low confidence (1)

src/gui/widgets/tonestack.rs:19

  • [nitpick] Consider reviewing the case and spacing in the header text for consistency; either use 'ToneStack' or 'Tonestack' uniformly across all widgets.
let mut header = row![text(format!("Tonestack {}", idx + 1))].spacing(5);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@OpenSauce OpenSauce merged commit 1988d0f into main Jun 7, 2025
2 checks passed
@OpenSauce OpenSauce deleted the swap-stages branch June 7, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant