Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces stage reordering functionality by adding move-up and move-down buttons to various stage widgets. Key changes include the addition of new messages (MoveStageUp and MoveStageDown), updating all stage widget functions to accept a total_stages parameter, and refactoring the header UI elements to use the new icon_button.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/gui/widgets/tonestack.rs | Added up/down buttons to reorder ToneStack stages and updated header text. |
| src/gui/widgets/preamp.rs | Added up/down buttons for Preamp stages with total stage count parameter. |
| src/gui/widgets/poweramp.rs | Introduced stage reordering and adjusted header alignment styling. |
| src/gui/widgets/filter.rs | Updated Filter widget with move-stage buttons and new total_stages parameter. |
| src/gui/widgets/compressor.rs | Integrated move-stage buttons into Compressor widget, similar to others. |
| src/gui/widgets/mod.rs | Added a reusable icon_button helper and ICONS_FONT constant. |
| src/gui/amp.rs | Added handling for MoveStageUp and MoveStageDown messages in the stage update logic. |
Comments suppressed due to low confidence (1)
src/gui/widgets/tonestack.rs:19
- [nitpick] Consider reviewing the case and spacing in the header text for consistency; either use 'ToneStack' or 'Tonestack' uniformly across all widgets.
let mut header = row![text(format!("Tonestack {}", idx + 1))].spacing(5);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be a better way of doing this but kept hitting issues