Add makefile, bump deps, and a little debug line#9
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the project's development workflow by adding a Makefile for standardized linting, testing, and formatting, along with minor runtime debug improvements in the processing module and an update to the logging level. Key changes include:
- Insertion of debug logging via the debug_stats function in src/io/processor.rs to provide runtime statistics.
- Modification of the buffer_size function signature to pass a proper client reference.
- Addition of a Makefile along with updates in CI workflow files and environment settings.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/io/processor.rs | Introduces debug_stats calls and updates buffer_size for enhanced runtime debugging. |
| src/io/manager.rs | Adds a TODO comment suggesting a future merge with processor.rs to reduce code duplication. |
| Makefile | Adds standardized targets for lint, clippy, fmt, and tests. |
| .github/workflows/lint.yaml | Updates the CI workflow to use the new Makefile targets. |
| .env | Updates the logging level from info to debug. |
Comments suppressed due to low confidence (2)
src/io/processor.rs:232
- Consider handling the case where client.buffer_size() returns 0 to avoid a potential division by zero in debug_stats.
debug!("Sample rate: {sample_rate}, Buffer frames: {buffer_frames}, Calls p/s: {}", sample_rate / buffer_frames);
src/io/manager.rs:1
- [nitpick] Review the long term plan to merge this file with src/io/processor.rs to reduce redundancy and improve maintainability.
// TODO: Merge the contents of this file with `src/io/processor.rs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.