Skip to content

Comments

Add makefile, bump deps, and a little debug line#9

Merged
OpenSauce merged 3 commits intomainfrom
add-makefile
May 25, 2025
Merged

Add makefile, bump deps, and a little debug line#9
OpenSauce merged 3 commits intomainfrom
add-makefile

Conversation

@OpenSauce
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 25, 2025 20:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the project's development workflow by adding a Makefile for standardized linting, testing, and formatting, along with minor runtime debug improvements in the processing module and an update to the logging level. Key changes include:

  • Insertion of debug logging via the debug_stats function in src/io/processor.rs to provide runtime statistics.
  • Modification of the buffer_size function signature to pass a proper client reference.
  • Addition of a Makefile along with updates in CI workflow files and environment settings.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/io/processor.rs Introduces debug_stats calls and updates buffer_size for enhanced runtime debugging.
src/io/manager.rs Adds a TODO comment suggesting a future merge with processor.rs to reduce code duplication.
Makefile Adds standardized targets for lint, clippy, fmt, and tests.
.github/workflows/lint.yaml Updates the CI workflow to use the new Makefile targets.
.env Updates the logging level from info to debug.
Comments suppressed due to low confidence (2)

src/io/processor.rs:232

  • Consider handling the case where client.buffer_size() returns 0 to avoid a potential division by zero in debug_stats.
debug!("Sample rate: {sample_rate}, Buffer frames: {buffer_frames}, Calls p/s: {}", sample_rate / buffer_frames);

src/io/manager.rs:1

  • [nitpick] Review the long term plan to merge this file with src/io/processor.rs to reduce redundancy and improve maintainability.
// TODO: Merge the contents of this file with `src/io/processor.rs`

@OpenSauce OpenSauce merged commit b1f472b into main May 25, 2025
2 checks passed
@OpenSauce OpenSauce deleted the add-makefile branch May 25, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant