Merged
Conversation
Add Open Graph and Twitter Card meta tags so sharing links on Slack, Discord, Twitter, etc. shows a proper preview card with the OSA branding image from osc.earth.
- Inline SVG OSA logo in header (uses currentColor for dark mode compatibility) - Dark mode CSS via prefers-color-scheme on demo page - Footer with dynamic year, heart, and OSC link - Consistent deep blue color palette across both pages
- Add dark mode to dashboard (matching frontend theme) - Add <meta name="description"> to both pages for SEO - Remove redundant twitter:title/description/image tags - Fix broken GitHub links (osc-em -> OpenScience-Collective) - Standardize org name to "OpenScience Collective" - Move dashboard inline styles to CSS classes - Rename .footer to .site-footer for consistency
* Enforce mandatory HED tag validation before display Fixes #210 * Address review: consistent error handling, sanitize exceptions
) * Fix sync status page: N/A display, all sync types, community-aware Fixes #212 - Fix Papers Sync showing N/A: sync_metadata stores source names like "openalex:query", not "openalex", so use prefix matching to find the most recent timestamp for each source type - Make /sync/status community-aware: accept community_id query param and query the correct community database (previously always used hed default) - Add all sync types to response: new 'syncs' field includes github, papers, docstrings, mailman, beps, faq with last_sync and next_run - Dashboard: pass community_id to sync status fetch, render all sync types dynamically including next scheduled run time * Address review findings: validation, future times, health endpoint - Validate community_id against registry (404 for unknown) - Update /sync/health to accept community_id param - Fix formatRelativeTime to handle future timestamps (next_run) - Use _parse_iso_datetime in _get_most_recent_sync for robust comparison - Fix misleading citing_doi comment in papers source lookup - Add exc_info=True to warning log calls for full tracebacks - Add tests: prefix matching regression, syncs field, unknown community 404 * Fix test: add isolated_db fixture to community_id test
- Fix papers last_sync timestamp comparison: use _parse_iso_datetime instead of string max() to avoid wrong result with mixed UTC offsets - Fix dashboard /sync/health URL: pass community_id param so health badge reflects the viewed community, not always 'hed' - Add tests for /sync/health community_id param: 404 for unknown, 200 for known community
- Add exc_info=True to trigger_sync error log for full tracebacks - Upgrade scheduler job inspection failure from warning to error
* Refactor CLI to thin client architecture (#215) Split heavy monolithic CLI into lightweight HTTP client (7 core deps) with optional [server] group for backend commands. Default API URL changed to https://api.osc.earth/osa. Add init/ask/chat commands, YAML config with credentials split, SSE streaming, BYOK headers. Server commands (serve/sync/validate) gated behind ImportError. Closes #215 * Address PR review findings - Fix TOCTOU race in save_credentials: use os.open with 0o600 mode - Add markup=False to print_error hint output - Replace fragile type-name string matching with specific httpx exceptions - Fix chat loop: catch httpx errors instead of broad Exception - Extract _stream_request to deduplicate SSE parsing in client - Skip old default localhost URL during legacy config migration - Fix misleading docstrings (_handle_response, ask, test_client) - Remove unused print_table from output module * Fix ANSI escape codes breaking help text assertions in CI Rich inserts color codes that split '--assistant' into separate tokens. Use click.unstyle() to strip ANSI before asserting. * Bump version to 0.7.0.dev0 for thin client refactor * Remove ExecutionConfig and standalone mode The CLI is a thin HTTP client only. Local agent execution is not supported; all queries go through the remote API. * Address final review findings - Move pydantic-settings to [server] optional deps (unused by thin client) - Use Literal type for OutputConfig.format instead of plain str - Add ValidationError to config/credentials load exception handlers - Fix dead code path in _ask_batch (AskResponse has no "message" field) - Replace behavioral mock with real file setup in health test
security.py used X-OpenRouter-API-Key but community router, widget, worker, and docs all use X-OpenRouter-Key. Aligned security.py to canonical name. Client sends both headers for backward compatibility with servers not yet updated.
- README: Fix CLI syntax (osa ask -a hed), add osa init, note server deps requirement for osa serve - DEPLOYMENT_ARCHITECTURE: Fix BYOK header name to X-OpenRouter-Key, update CLI commands, remove standalone mode references - local-testing-guide: Fix CLI flags (--community/--standalone removed)
Code simplification: - Extract _get() helper and _chat_payload() static method in client.py - Simplify legacy migration with dict comprehension - Extract patched_config_paths fixture to reduce test boilerplate Error handling fixes: - Narrow broad except Exception to specific httpx exceptions in init and health commands - Add stub commands for sync/validate when server deps missing (instead of silently hiding commands) - Add debug logging for malformed SSE data lines
Dispatches a repository_dispatch event to the documentation repo so it can auto-update the OSA submodule and open a sync PR. Requires DOCS_REPO_TOKEN secret (fine-grained PAT with Contents read/write on the documentation repo).
* Surface community config health via public API
Downgrade noisy API key warning from error to debug level
in discover_assistants() so it stops spamming CLI users.
Extract compute_community_health() helper in health.py and
add config_health to GET /{community_id}/metrics/public and
status field to GET /{community_id}/ config response.
Warnings clearly communicate that using the shared platform
key is for demonstration only and not sustainable.
Closes #220
* Address PR review: fix error handling and security
- Move compute_community_health() call inside try/except in
get_communities_health() to restore error containment
- Add try/except around health computation in config and
public metrics endpoints so failures don't crash them
- Sanitize warnings for public endpoint: strip env var names
to prevent information disclosure
- Change logger.debug to logger.warning in discover_assistants
so operators see missing key warnings at startup
- Move inline imports to top-level (no circular import risk)
- Remove redundant "error" key from fallback dict
* Fix CI: initialize temp metrics DB in health status tests
The public metrics tests need a metrics DB to avoid 503.
Use the same tmp_path + patch pattern as test_metrics_public.
Display config_health data from /metrics/public API on the frontend status page. Shows orange banner for degraded status (using platform key) and red banner for error status (missing API key). Part of issue #220.
Communities without openrouter_api_key_env_var configured were silently using the platform key with no warning. Now all communities without a dedicated API key show a warning on the status dashboard.
* Add community-specific logos to chat widget (#224) Support custom logos in widget header avatar with three-tier precedence: widget JS setConfig override, YAML logo_url field, and convention-based logo file detection in community folders. * Address PR review findings - Add CSP header for SVG responses to prevent XSS - Add onerror fallback on img to restore brain icon - Wrap _find_logo_file in OSError handling - Add URL scheme validator on logo_url field - Rename to find_logo_file (public API, no underscore) - Extract convention_logo_url helper to deduplicate - Remove redundant _LOGO_EXTENSIONS constant - Fix docstrings: "Override" -> "Fallback", file list - Fix comment: "relative" -> "path-only" - Add TOCTOU guard in /logo endpoint - Set explicit filename in FileResponse
* Add FieldTrip community, generalize docstring/FAQ tools - Add FieldTrip EEG community config with 30+ docs, docstrings, citations, widget theme color (#008a79), and sync schedules - Wire up _build_tools() to auto-generate docstring and FAQ tools from community config (include_docstrings, include_faq) - Add sqlite3.OperationalError handling to generic tool factories - Migrate EEGLAB from custom tools.py to generic factory - Add theme_color support to WidgetConfig model and frontend widget - Update EEGLAB integration tests for generic factory tools Closes #225 * Address PR review findings - Narrow OperationalError catch to "no such table" only; re-raise infrastructure errors (corruption, disk full, permissions) - Add structured logging context (query, community) to warnings - Remove duplicate theme color block in applyWidgetConfig() - Add hex color regex validation before parseInt in widget JS - Add mailman check to has_faq condition for precision * Add tests for review findings and fix issues - Add tests for OperationalError handling (missing table scenario) - Add tests for create_knowledge_tools with docstrings/FAQ flags - Add tests for WidgetConfig theme_color validation and resolve() - Add docstring/FAQ tool checks to generic community test suite - Narrow OperationalError catch to "no such table" only - Add hex color regex validation in widget JS - Remove duplicate theme color block in applyWidgetConfig() - Tighten has_faq condition to require mailman config
neuromechanist
changed the title
3 tasks
- Add logging to silent except blocks in CLI config/credentials
loading so failures are visible to users and operators
- Log credential permission fallbacks with security warnings
- Upgrade SSE malformed event log from debug to warning level
- Narrow bare except Exception to specific types in health
computation and LangFuse tracing setup
- Restore structured extra={} dict in env var warning log
- Add logo feature tests: URL validator, find_logo_file,
convention_logo_url, /logo endpoint (CSP, 404, media types),
resolve() fallback precedence
Member
Author
Release 0.7.0 PR Review SummaryRan 3 review agents: code-reviewer, silent-failure-hunter, test-analyzer. Code-Reviewer: Clean for mergeNo integration-level issues found. Individual features compose correctly, BYOK header migration is consistent, no credentials exposed. Silent-Failure-Hunter: 4 Critical, 4 High, 3 MediumAll addressed in PR #228 (merged to develop):
Test-Analyzer: 3 Critical GapsAll addressed in PR #228:
Result
|
# Conflicts: # src/version.py
Contributor
Preview Deployment
This preview will be updated automatically when you push new commits. |
Contributor
Dashboard Preview
This preview will be updated automatically when you push new commits. |
* feat: onboard MNE-Python community with Discourse syncer Add MNE-Python as a new community with 31 documentation pages, 5 GitHub repos, 5 citation DOIs, Python docstring extraction, and Discourse forum sync. Build a generic Discourse syncer using the public JSON API with patient rate limiting (1 req/s). Key changes: - MNE community config (config.yaml) with full ecosystem - Generic Discourse syncer (discourse_sync.py) with incremental sync - DB schema: discourse_topics table with FTS5 search - HTML-to-markdown auto-conversion in doc fetcher (for Sphinx docs) - Discourse search tool factory and CLI sync command - DiscourseCategoryConfig and SyncConfig.discourse schema additions - Tests for DB, search, config validation, and live API Closes #229 * fix: address PR review findings for Discourse syncer - Wrap per-topic sync loop in try/except to prevent single bad topic from crashing the entire sync - Use .get() for topic id/slug to avoid KeyError on malformed API responses - Add logging when listing pagination fails - Move get_last_sync to top-level import - Include discourse count in sync_all total_items summary - Remove redundant snippet truncation in discourse tool * Add missing tests for discourse tools and helpers - TestSearchDiscourseTool: missing table, no results, correct naming - TestHtmlToText: simple HTML, empty input, code blocks, whitespace - TestGetAcceptedAnswer: accepted answer, fallback to liked, no replies - Updated test_includes_all_optional_tools to include discourse * Fix comment accuracy issues from review - Rename _html_to_text to _html_to_markdown (matches actual behavior) - Fix _get_accepted_answer docstring: "most-liked" not "highest-scoring" - Update get_last_sync/update_sync_metadata docs to include 'discourse' * Improve type safety for Discourse category config - Use DiscourseCategoryConfig directly instead of list[dict] - Remove model_dump() type laundering in sync.py - Add field validation: slug pattern, id >= 1 - Change accepted_answer_snippet to str | None
Contributor
|
This PR modifies community CORS origins. Worker changes detected. After merging to Manual deployment (if needed): cd workers/osa-worker
wrangler deploy --env dev # for develop branch
wrangler deploy # for main branch |
Not yet onboarded by their maintainers; only hosted on demo.osc.earth for now. Left TODO comments for maintainers to submit PRs when ready.
Member
Author
Release 0.7.0 - PR Review SummaryReviewed with 3 specialized agents: code-reviewer, silent-failure-hunter, pr-test-analyzer. Critical Issues: 0High Priority (non-blocking, defensive improvements)
Medium Priority (8 items)
Test Gaps (non-blocking)
Strengths
VerdictNo critical issues. High-priority items are defensive edge-case improvements, not production blockers. Release is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 0.7.0 merges develop into main, covering all features and fixes since 0.6.7.
Features
pip install open-science-assistantpulls ~7 deps, BYOK via header forwarding, server deps optional with[server]extraFixes
Infrastructure
Test plan