Address release 0.7.0 review findings#228
Merged
neuromechanist merged 1 commit intodevelopfrom Feb 25, 2026
Merged
Conversation
- Add logging to silent except blocks in CLI config/credentials
loading so failures are visible to users and operators
- Log credential permission fallbacks with security warnings
- Upgrade SSE malformed event log from debug to warning level
- Narrow bare except Exception to specific types in health
computation and LangFuse tracing setup
- Restore structured extra={} dict in env var warning log
- Add logo feature tests: URL validator, find_logo_file,
convention_logo_url, /logo endpoint (CSP, 404, media types),
resolve() fallback precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all findings from the PR #218 release review (code-reviewer, silent-failure-hunter, test-analyzer).
Error Handling (C1-C4, H1-H3)
logger.warningto silent except blocks in CLIload_config(),load_credentials(),_migrate_legacy_config()debugtowarninglevelexcept Exceptionto(AttributeError, KeyError, TypeError)in health computationexcept Exceptionto(AttributeError, ValueError, RuntimeError, OSError, ImportError)in LangFuse tracingStructured Logging (H4)
extra={}dict in env var warning log for observability toolsTest Coverage (T1-T3)
TestWidgetConfigLogoUrl: 12 tests for URL validator (XSS prevention), resolve() fallback precedenceTestFindLogoFile: 4 tests for convention-based file detectionTestConventionLogoUrl: 3 tests for helper functionTestLogoEndpoint: 4 tests for SVG CSP header, 404, media typesTestLogoInCommunityConfig: 1 test for logo_url in API responsesTest plan