Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces root main components for desktop modules and updates various package dependencies. The primary purpose is to add support for modules that have a single main component as an alternative to the existing navigation-based module system.
- Added
RootComponentproperty toDesktopModuleBasefor modules with a single main component - Updated module page logic to handle both root components and navigation-based components
- Updated multiple package dependencies across the project
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ModuleBase/DesktopModuleBase.cs | Added RootComponent property and comprehensive documentation for the module base class |
| Desktop/Ui/Pages/Dash/ModulePage.razor | Modified to support rendering root components and improved component resolution logic |
| Desktop/Ui/Pages/Dash/Components/ModuleNavComponent.razor | Added conditional rendering for modules with root components |
| Desktop/ModuleFileProvider.cs | Fixed null reference issues with subscription disposal |
| ModuleBase/ModuleBase.csproj | Updated Microsoft.AspNetCore.Components.Web to version 9.0.8 |
| ExampleModule/ExampleModule.csproj | Updated MudBlazor to version 8.11.0 |
| Desktop/Desktop.csproj | Updated multiple Microsoft packages and dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.