Conversation
|
Digits10Count(T val) previously used `val = -val` to obtain the magnitude for negative signed integers. This causes signed overflow for the most negative representable value (e.g. INT_MIN, LLONG_MIN), resulting in undefined behavior. The fix mirrors the logic used in the string-conversion code: convert the value to its corresponding unsigned type and use a modular negation (`U(0) - U(val)`) to obtain the magnitude safely and portably. This ensures correct digit counting for all integral types without invoking UB. Additional improvements: - Decay T to remove cv/ref qualifiers before applying type traits. - Use std::make_unsigned_t for consistent unsigned magnitude handling.
Contributor
Cpp-Linter Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current impl has a bug with signed integer minimum values