feat: add OIDC logout handling and public theme endpoint#1345
Closed
boehlke wants to merge 4 commits intoOpenSlides:feature/relational-dbfrom
Closed
feat: add OIDC logout handling and public theme endpoint#1345boehlke wants to merge 4 commits intoOpenSlides:feature/relational-dbfrom
boehlke wants to merge 4 commits intoOpenSlides:feature/relational-dbfrom
Conversation
Add logout error type, SSE logout notification, HTTP handler extension, and database pool passing for OIDC authentication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
Theme serving has been moved to the backend presenter service. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove manual JSON formatting for logout errors and let them fall through to the existing ClientError branch, keeping a single point of JSON formatting. Remove redundant Reason() method from logoutError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The autoupdate service code uses auth.LogoutError which was added in commit 9224a36 on the kryptance fork. Add a replace directive so Go fetches from the fork, fixing the CI build failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
ostcar
reviewed
Feb 23, 2026
| golang.org/x/text v0.33.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/OpenSlides/openslides-go => github.com/kryptance/openslides-go v0.0.0-20260219070754-9224a36bfe96 |
Member
There was a problem hiding this comment.
You can use the go work feature with the same effect without editing this file.
go work init . ../openslides-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.New()for OIDC user resolution/system/themeendpoint for Keycloak login page themingContext
Part of the Keycloak OIDC integration. Depends on openslides-go#170 for the updated
auth.New()signature.Related PRs:
Test plan
make dev oidcstarts autoupdate service with OIDC support/system/themeendpoint returns theme data without authentication🤖 Generated with Claude Code