-
Notifications
You must be signed in to change notification settings - Fork 32
[rel-DB] Sequential numbers cleanup #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rel-DB] Sequential numbers cleanup #3174
Conversation
b680a2e to
6c6ed51
Compare
676374c to
da1114e
Compare
|
|
hjanott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure that in a meeting import with sequential number models old sequences are not applied. Just use some collection and assert that an unwanted value is overwritten with the next sequence number by the database anyway.
| self.assert_model_exists( | ||
| "assignment/1", | ||
| { | ||
| "title": "test_Xcdfgee", | ||
| "meeting_id": 110, | ||
| "open_posts": 0, | ||
| "phase": "search", | ||
| "sequential_number": 1, | ||
| }, | ||
| ) | ||
| self.assert_model_exists( | ||
| "agenda_item/1", {"meeting_id": 110, "content_object_id": "assignment/1"} | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it's more lines, this way is so much easier to read. Love it.
Out of all the affected collections only |
|
Updated the meeting.import test to check the changes from OpenSlides/openslides-meta@a1d976c Added issue for the similar test in meta: OpenSlides/openslides-meta#336 |
hjanott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
|
Needs changes from OpenSlides/openslides-meta#343 |
ab93656
into
OpenSlides:feature/relational-db
Integrates changes from OpenSlides/openslides-meta#319
Current changes in the generation logic:
Other changes:
test_create_set_used_as_default_in_meeting_id. Reason - 1_1 trigger: now we can't have a meeting withoutused_as_default_projector_for_topic_in_meeting_id, so before the request we already have one.