Remove the meeting_user when removing a user from a meeting

[luisa-beerboom]

Closes #2111
Closes #3133
See OpenSlides/openslides-meta#347

• user.update now deletes the meeting user when the group_ids are emptied. (Uses custom meeting_user.delete class bc using the actual one would cause circular dep exceptions)
• motion.create doesn't automatically assign the calling user anymore. The chosen submitters now need to be given as meeting_user ids via the new field submitter_meeting_user_ids instead of how it was done before (as user ids via the field submitter_ids)
• chat_message.create now only works if the user is in the meeting
• same with personal notes

TODO:

• Write migration
• Take care of supporter after PR Implement motion_supporter model #3173 is merged
• remaining tests in migration (see todos in code)
• Write client issue for this (motion create should auto-fill submitter if possible)

[hjanott]

With this change it will be impossible to remove a user from a meeting and rejoin him with all relations to meeting user submodels set in place again because the information is lost.
In general I'm against this change unless the user_id is stored in all meeting_user related models as well. However that's also not well designed.

[hjanott]

It would be more efficient to filter all meeting users where group_ids is empty list or None.

[luisa-beerboom]

Did that initially. Didn't work.

If you have an idea on how to improve

        filter_ = And(
            Or(
                FilterOperator("group_ids", "=", None),
                FilterOperator("group_ids", "=", []),
            ),
            FilterOperator("meta_deleted", "!=", True),
        )
        musers_to_delete = self.reader.filter(
            "meeting_user",
            filter_,
            list(COLLECTION_TO_MIGRATION_FIELDS["meeting_user"]),
        )

so it doesn't return an empty dict every time, feel free to tell me.

[hjanott]

This seems to be an issue with psycopg 2 and/or the json formatting of our models. If you send the empty list as a string it should work.

[luisa-beerboom]

Done

[Elblinator]

If a participant is allowed to create motions/amendments but cannot manage motions/ meta data the backend is stopping the participant from creating the motion/amenment:

Motion:

{
  "action": "motion.create",
  "data": [
    {
      "meeting_id": 1,
      "title": "we",
      "text": "<p>e</p>",
      "submitter_meeting_user_ids": [
        2
      ],
      "workflow_id": 1
    }
  ]
}

Response:

{
    "success": false,
    "message": "You are not allowed to perform action motion.create. Forbidden fields: submitter_meeting_user_ids with possibly needed permission(s): motion.can_manage, motion.can_manage_metadata"
}

Amendment:

payload: 
{
  "action": "motion.create",
  "data": [
    {
      "meeting_id": 1,
      "lead_motion_id": 11,
      "title": "Änderungsantrag zu 01",
      "submitter_meeting_user_ids": [
        2
      ],
      "workflow_id": 1,
      "reason": "",
      "amendment_paragraphs": {
        "0": "<p>s gxd.kui hg bvear ertg</p>"
      }
    }
  ]
}

response:

{
    "success": false,
    "message": "You are not allowed to perform action motion.create. Forbidden fields: submitter_meeting_user_ids with possibly needed permission(s): motion.can_manage, motion.can_manage_metadata"
}

[hjanott]

LGTM and IMO can be merged once the docs got updated.
For documentation purposes: It was decided that we will deliberately take the information loss and irredeemably delete the connection between the user and all its remaining meeting_user submodels every time removing a user from a meeting.

[hjanott]

Name needs to also be changed in the payload description.

[luisa-beerboom]

Done

[hjanott]

I saw this in other places too.

Suggested change

	Motion.CAN_MANAGE_METADATA and User.CAN_SEE when sending submitter_ids.
	Motion.CAN_MANAGE_METADATA and User.CAN_SEE when sending submitter_meeting_user_ids.

[luisa-beerboom]

Done