[rel-DB] Merge main#3228
Conversation
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
Tests aren't being run by the github actions due to a failing docker container. That is new. Maybe you can find the reason together with @Janmtbehrens.
…ch for dev docker compose setup
|
@hjanott in addition to yesterday's changes returned 2 blocks of code removed during merging:
|
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
That was a lot thank you! I have some requests.
| ) and (to_remove := content.get(field_name)): | ||
| if isinstance(to_remove, list): | ||
| for target in to_remove: | ||
| self.remove_back_relation( |
There was a problem hiding this comment.
This kinda thing shouldn't be necessary anymore right? Should we fill this into a separate issue?
There was a problem hiding this comment.
Same as above: code already works in rel-db and some of meeting.import and tests are still failing. Let's leave this for the cleanup stage.
There was a problem hiding this comment.
IMO this should be handled in a separate issue together with the cleanup of meeting.clone, export_helper and checker - all of them are currently dealing with list relations and for meeting.clone we need all the 3 others components.
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
vkrasnovyd
merged commit 67aa99e
into
OpenSlides:feature/relational-db
9 participants
Needs OpenSlides/openslides-meta#355
Most of the code adjustments - updating import pathes, making field values serializable and removing back relations from
set_models()in the tests.The only logic changes are in this commit: 864a189.