Remove SymbolicAWEModel code from the package

[1-Bart-1]

Use SymbolicAWEModels.jl instead.

[ufechner7]

Please, fix the tests first.

[1-Bart-1]

There are 3 options when using a unique find_steady_state! function from SymbolicAWEModels in the example. I don't like any of them...

1. Problem: Bad to write

using KiteModels
KiteModels.SymbolicAWEModels.find_steady_state!

2. Problem: Why would you still import KiteModels, just importing SymbolicAWEModels would still make the example work

using KiteModels, SymbolicAWEModels
SymbolicAWEModels.find_steady_state!

3. Problem: this is basically the same as 2, and this causes problems with aqua.

src/KiteModels.jl
@reexport SymbolicAWEModels

examples/ram_air_kite.jl
using KiteModels
SymbolicAWEModels.find_steady_state!

[ufechner7]

You can always write:

using KiteModels
using KiteModels.SymbolicAWEModels: find_steady_state!

to make clear you want to import the find_stead_state! function from SymbolicAWEModels, if that is what you want to do.

[1-Bart-1]

That doesn't make it easier to understand or run the example, but I'll do that for now.

[1-Bart-1]

Fixed the tests

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[ufechner7]

I get the following error when creating a sys image:

└ @ ModelingToolkit.StructuralTransformations ~/.julia/packages/ModelingToolkit/vyvd9/src/structural_transformation/utils.jl:291
ERROR: LoadError: MethodError: no method matching find_steady_state!(::SymbolicAWEModel)
The function find_steady_state! exists, but no method is defined for this combination of argument types.

Closest candidates are:
find_steady_state!(::KPS3; prn, delta, stiffness_factor, upwind_dir)
@ KiteModels ~/repos/KiteModels.jl/src/KPS3.jl:525
find_steady_state!(::KPS4; prn, delta, stiffness_factor, upwind_dir)
@ KiteModels ~/repos/KiteModels.jl/src/KPS4.jl:650

Stacktrace:
[1] top-level scope
@ /repos/KiteModels.jl/test/test_for_precompile.jl:116
in expression starting at /home/ufechner/repos/KiteModels.jl/test/test_for_precompile.jl:105
ERROR: LoadError: failed process: Process(setenv(/home/ufechner/.julia/juliaup/julia-1.11.7+0.x64.linux.gnu/bin/julia --color=yes --startup-file=no --pkgimages=no --sysimage=/home/ufechner/.julia/juliaup/julia-1.11.7+0.x64.linux.gnu/lib/julia/sys.so --compile=all --trace-compile=/tmp/jl_packagecompiler_AN2Fr1/jl_bIu5CT test/test_for_precompile.jl,["QT_ACCESSIBILITY=1", "USE_REVISE=false", "DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus", "XDG_SESSION_TYPE=wayland", "SYSTEMD_EXEC_PID=5728", "USER=ufechner", "XDG_CONFIG_DIRS=/etc/xdg/xdg-ubuntu:/etc/xdg", "LESSCLOSE=/usr/bin/lesspipe %s %s", "LC_NUMERIC=nl_NL.UTF-8", "LC_MEASUREMENT=nl_NL.UTF-8" … "VSCODE_GIT_ASKPASS_MAIN=/usr/share/code/resources/app/extensions/git/dist/askpass-main.js", "ORIGINAL_XDG_CURRENT_DESKTOP=ubuntu:GNOME", "MAMBA_EXE=/home/ufechner/.julia/artifacts/87052ac9aec71548f804b30280151288cb1ed40e/bin/micromamba", "LC_NAME=nl_NL.UTF-8", "JOURNAL_STREAM=8:41121", "LC_IDENTIFICATION=nl_NL.UTF-8", "JULIA_LOAD_PATH=/tmp/jl_5fUppg:@stdlib", "GIO_LAUNCHED_DESKTOP_FILE_PID=24569", "MAMBA_ROOT_PREFIX=/home/ufechner/micromamba", "LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=00:tw=30;42:ow=34;42:st=37;44:ex=01;32:.tar=01;31:.tgz=01;31:.arc=01;31:.arj=01;31:.taz=01;31:.lha=01;31:.lz4=01;31:.lzh=01;31:.lzma=01;31:.tlz=01;31:.txz=01;31:.tzo=01;31:.t7z=01;31:.zip=01;31:.z=01;31:.dz=01;31:.gz=01;31:.lrz=01;31:.lz=01;31:.lzo=01;31:.xz=01;31:.zst=01;31:.tzst=01;31:.bz2=01;31:.bz=01;31:.tbz=01;31:.tbz2=01;31:.tz=01;31:.deb=01;31:.rpm=01;31:.jar=01;31:.war=01;31:.ear=01;31:.sar=01;31:.rar=01;31:.alz=01;31:.ace=01;31:.zoo=01;31:.cpio=01;31:.7z=01;31:.rz=01;31:.cab=01;31:.wim=01;31:.swm=01;31:.dwm=01;31:.esd=01;31:.avif=01;35:.jpg=01;35:.jpeg=01;35:.mjpg=01;35:.mjpeg=01;35:.gif=01;35:.bmp=01;35:.pbm=01;35:.pgm=01;35:.ppm=01;35:.tga=01;35:.xbm=01;35:.xpm=01;35:.tif=01;35:.tiff=01;35:.png=01;35:.svg=01;35:.svgz=01;35:.mng=01;35:.pcx=01;35:.mov=01;35:.mpg=01;35:.mpeg=01;35:.m2v=01;35:.mkv=01;35:.webm=01;35:.webp=01;35:.ogm=01;35:.mp4=01;35:.m4v=01;35:.mp4v=01;35:.vob=01;35:.qt=01;35:.nuv=01;35:.wmv=01;35:.asf=01;35:.rm=01;35:.rmvb=01;35:.flc=01;35:.avi=01;35:.fli=01;35:.flv=01;35:.gl=01;35:.dl=01;35:.xcf=01;35:.xwd=01;35:.yuv=01;35:.cgm=01;35:.emf=01;35:.ogv=01;35:.ogx=01;35:.aac=00;36:.au=00;36:.flac=00;36:.m4a=00;36:.mid=00;36:.midi=00;36:.mka=00;36:.mp3=00;36:.mpc=00;36:.ogg=00;36:.ra=00;36:.wav=00;36:.oga=00;36:.opus=00;36:.spx=00;36:.xspf=00;36:=00;90:#=00;90:.bak=00;90:.crdownload=00;90:.dpkg-dist=00;90:.dpkg-new=00;90:.dpkg-old=00;90:.dpkg-tmp=00;90:.old=00;90:.orig=00;90:.part=00;90:.rej=00;90:.rpmnew=00;90:.rpmorig=00;90:.rpmsave=00;90:.swp=00;90:.tmp=00;90:.ucf-dist=00;90:.ucf-new=00;90:*.ucf-old=00;90:"]), ProcessExited(1)) [1]

Stacktrace:
[1] pipeline_error
@ ./process.jl:598 [inlined]
[2] run(::Cmd; wait::Bool)
@ Base ./process.jl:513
[3] run
@ ./process.jl:510 [inlined]
[4] run_precompilation_script(project::String, sysimg::String, precompile_file::String, precompile_dir::String)
@ PackageCompiler ~/.julia/packages/PackageCompiler/FtDNu/src/PackageCompiler.jl:314
[5] create_sysimg_object_file(object_file::String, packages::Vector{String}, packages_sysimg::Set{Base.PkgId}; project::String, base_sysimage::String, precompile_execution_file::Vector{String}, precompile_statements_file::Vector{String}, cpu_target::String, script::Nothing, sysimage_build_args::Cmd, extra_precompiles::String, incremental::Bool, import_into_main::Bool)
@ PackageCompiler ~/.julia/packages/PackageCompiler/FtDNu/src/PackageCompiler.jl:353
[6] create_sysimg_object_file
@ ~/.julia/packages/PackageCompiler/FtDNu/src/PackageCompiler.jl:319 [inlined]
[7] create_sysimage(packages::Vector{Symbol}; sysimage_path::String, project::String, precompile_execution_file::String, precompile_statements_file::Vector{String}, incremental::Bool, filter_stdlibs::Bool, cpu_target::String, script::Nothing, sysimage_build_args::Cmd, include_transitive_dependencies::Bool, base_sysimage::Nothing, julia_init_c_file::Nothing, julia_init_h_file::Nothing, version::Nothing, soname::Nothing, compat_level::String, extra_precompiles::String, import_into_main::Bool)
@ PackageCompiler ~/.julia/packages/PackageCompiler/FtDNu/src/PackageCompiler.jl:644
[8] top-level scope
@ ~/repos/KiteModels.jl/test/create_sys_image.jl:20
[9] include(fname::String)
@ Main ./sysimg.jl:38
[10] top-level scope
@ none:1
in expression starting at /home/ufechner/repos/KiteModels.jl/test/create_sys_image.jl:20

Any idea?