Skip to content

Feat: remove double error printing #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanjayankur31 merged 2 commits into from
Jul 2, 2025
Merged

Feat: remove double error printing #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6319a
feat(inout): remove duplicate error print
sanjayankur31 Jul 2, 2025
fdd51eb
chore: syntactic tweaks
sanjayankur31 Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions omv/common/inout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,29 +120,18 @@ def check_output(cmds, cwd=".", shell=False, verbosity=0, env=None):
return ret_string

except sp.CalledProcessError as err:
inform(
"CalledProcessError running commands: %s in %s (return code: %s), output:\n%s"
% (cmds, cwd, err.returncode, err.output),
indent=2,
verbosity=verbosity,
)
inform("Error: %s" % (err), indent=2, verbosity=verbosity)
raise err
except Exception as err:
inform(
"Error running commands: %s in (%s)!" % (cmds, cwd),
indent=2,
verbosity=verbosity,
)
inform("Error: %s" % (err), indent=2, verbosity=verbosity)
raise err


def pip_install(packages, version=None):
pip = "pip3" if sys.version_info.major == 3 else "pip"
cmds = [pip, "install"]
if type(packages) == str:
if version == None:
if isinstance(packages, str):
if version is None:
cmds.append(packages)
else:
cmds.append("%s==%s" % (packages, version))
Expand Down