Improve error messages from concatenated functions.#74
Open
hmgaudecker wants to merge 1 commit intouse-jb-for-docsfrom
Open
Improve error messages from concatenated functions.#74hmgaudecker wants to merge 1 commit intouse-jb-for-docsfrom
hmgaudecker wants to merge 1 commit intouse-jb-for-docsfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## use-jb-for-docs #74 +/- ##
===================================================
- Coverage 95.45% 95.37% -0.09%
===================================================
Files 25 25
Lines 1167 1188 +21
===================================================
+ Hits 1114 1133 +19
- Misses 53 55 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Set __name__ on the inner function so signature enforcement produces "The concatenated function is missing ..." instead of "concatenated() missing ...". Drop "()" from all _fail_if_* format strings and add "is" before "missing". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hmgaudecker
force-pushed
the
improve-error-message
branch
from
74c5da3 to
99167fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
__name__on the inner function so signature enforcement produces:instead of
Drop "()" from all fail_if* format strings and add "is" before "missing".
Note: Since the same error message is used by
with_signature, we can't just change the error message itself.