Add manual calibration feature for analog sticks #1528
+457
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: - Add independent manual calibration for analog sticks 1 and 2 - Implement 4-step calibration process (top-left, top-right, bottom-left, bottom-right) - Add complete i18n support (English/Chinese) for calibration messages - Support parameterized messages for dynamic content Technical changes: - Add joystick_center_x/y/x2/y2 fields to config proto - Add manual calibration API endpoints (/api/getJoystickCenter, /api/getJoystickCenter2) - Update analog input logic to support manual calibration values - Add comprehensive frontend calibration interface with step-by-step guidance - All code comments written in English as per project standards - Clean code without duplicate comments or code blocks
Contributor
|
Thank you for submitting this!! I'm going to wait on reviewing/merging until after our release. |
Contributor
|
It looks like its working but I want to touch up the UI a bit. I'll see if I can mock up a modal so you can just rotate the stick like Microsoft or any of the calibration software does and real-time feed it using an adc_read. |
Author
|
Thank you for making it even better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Technical changes: