Fix RendererLeafView.makeLeafView(view:inputs:) #611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookjw
force-pushed
the
feature/implement_makeLeafView
branch
2 times, most recently
from
5555e22 to
1bf9d8a
Compare
pookjw
force-pushed
the
feature/implement_makeLeafView
branch
from
1bf9d8a to
d2cb6b2
Compare
Kyle-Ye
reviewed
Oct 28, 2025
| options: .defaultValue, | ||
| contentSeed: .init() | ||
|
|
||
| if inputs.preferences.requiresDisplayList { |
Collaborator
There was a problem hiding this comment.
This is needed on ViewHidden. And I have fixed in #612
Comment on lines
+48
to
+57
| if inputs.preferences.requiresViewResponders { | ||
| outputs.preferences.viewResponders = Attribute( | ||
| LeafResponderFilter( | ||
| data: view.value, | ||
| size: inputs.animatedSize(), | ||
| position: inputs.animatedPosition(), | ||
| transform: inputs.transform | ||
| ) | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
Gesture and ViewResponder system is not ready yet. And this PR does not implement them either.
| package typealias Value = [ViewResponder] | ||
|
|
||
| package func updateValue() { | ||
| _openSwiftUIUnimplementedWarning() |
Collaborator
There was a problem hiding this comment.
We'll implement and test it when Gesture is ready. Looks like currently we do not need those.
Kyle-Ye
changed the title
Collaborator
|
Close since conflict and it does not add any new feature or fix bug IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.