Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 3, 2026

Close #701

When all items are removed, no crash should happen.

@augmentcode
Copy link

augmentcode bot commented Jan 3, 2026

🤖 Augment PR Summary

Summary: Prevents an assertion/crash when a DynamicContainer becomes empty (closes #701).

Change: Relaxes the inusedCount assertion in DynamicContainerInfo.updateValue() to allow 0 items after removals.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.76%. Comparing base (ab517e3) to head (525e854).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #705       +/-   ##
===========================================
+ Coverage   14.29%   28.76%   +14.47%     
===========================================
  Files         563      589       +26     
  Lines       33190    35836     +2646     
===========================================
+ Hits         4743    10307     +5564     
+ Misses      28447    25529     -2918     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit e30f180 into main Jan 3, 2026
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch January 3, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DynamicContainer assertion crash

2 participants