Skip to content

Fix AlignmentKey.bits calculation logic #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pookjw wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix AlignmentKey.bits calculation logic #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/OpenSwiftUICore/Layout/Alignment/AlignmentGuide.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,7 @@ public struct AlignmentKey: Hashable, Comparable {
package var axis: Axis { bits & 1 == 0 ? .horizontal : .vertical }

@inline(__always)
var index: Int { Int(bits / 2 - 1) }
var index: Int { Int((bits - 2) >> 1) }

package init(id: any AlignmentID.Type, axis: Axis) {
let index = Self.$typeCache.access { cache in
Expand All @@ -1255,7 +1255,7 @@ public struct AlignmentKey: Hashable, Comparable {
return index
}
}
bits = (axis == .horizontal ? 0 : 1) + (index + 1) * 2
bits = ((index << 1) | (axis == .horizontal ? 0 : 1)) &+ 2
}

package init() { bits = .zero }
Expand Down
Loading