Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 11, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 11, 2026

🤖 Augment PR Summary

Summary: Updates image-orientation support and begins migrating Image toward a provider-based resolution model.

Changes:

  • Refactors Image to store an ImageProvider box and adds ImageResolutionContext scaffolding (currently WIP/blocked).
  • Moves Image.Orientation into a dedicated file and adds CoreGraphics helpers on CGSize/CGRect/CGAffineTransform to apply/unapply orientation.
  • Adds HDR/dynamic-range API (Image.DynamicRange, allowedDynamicRange(_:)) plus corresponding EnvironmentValues keys.
  • Adds protobuf enum bridging for Image.DynamicRange and Image.Orientation.
  • Adds unit tests and SwiftUI dual-tests, and updates the symbol-locator C stubs to cover the new orientation APIs.

Technical Notes: Several image-resolution/view-rendering pieces intentionally remain _openSwiftUIUnimplementedFailure() and are marked as blocked/WIP.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 53.41615% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.82%. Comparing base (7e32912) to head (d2209cf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUICore/View/Image/ImageDynamicRange.swift 0.00% 44 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 29 Missing ⚠️
...ources/OpenSwiftUICore/View/Image/NamedImage.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   28.73%   28.82%   +0.08%     
==========================================
  Files         589      592       +3     
  Lines       35991    36140     +149     
==========================================
+ Hits        10342    10416      +74     
- Misses      25649    25724      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/view/image branch from 85d8242 to d2209cf Compare January 11, 2026 18:00
@Kyle-Ye Kyle-Ye merged commit d0249df into main Jan 11, 2026
8 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/view/image branch January 11, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants