Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 17, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: This PR replaces the previous placeholder image types with a more complete image resolution pipeline centered around a new GraphicsImage and Image.Resolved.

Changes:

  • Moved GraphicsImage out of DisplayList (removing the empty stub) and introduced a new Sources/OpenSwiftUICore/View/Image/GraphicsImage.swift with content variants, sizing/orientation helpers, and style resolver integration.
  • Implemented CGImageProvider.resolve(in:) to produce Image.Resolved, including dynamic range computation and redaction behavior.
  • Added ResolvedImage.swift defining Image.Resolved, layout metrics scaffolding, and basic provider/view conformances (some still WIP).
  • Implemented previously-WIP image modifiers: interpolation, antialiasing, and resizable behavior by mutating the resolved GraphicsImage.
  • Added _ShapeStyle_ResolverMode initializer for symbol style masks and updated orientation utilities (mirroring + horizontal detection) used in size calculations.
  • Introduced an ImageAccessibilityProvider hook in graph/view inputs and added CoreGraphics private shim support for querying CGImage headroom.

Technical Notes: The new flow computes effective HDR constraints via ImageResolutionContext.effectiveAllowedDynamicRange(for:) and uses EnvironmentValues.shouldRedactContent to substitute a low-opacity foreground color when redacting.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye force-pushed the feature/resolved_image branch from d3915af to 16ee4e9 Compare January 17, 2026 11:38
@Kyle-Ye Kyle-Ye force-pushed the feature/resolved_image branch from 4b38ebf to a6ab412 Compare January 17, 2026 12:20
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 7.48031% with 235 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.33%. Comparing base (3916a7c) to head (a6ab412).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ces/OpenSwiftUICore/View/Image/GraphicsImage.swift 12.19% 72 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/ResolvedImage.swift 0.00% 63 Missing ⚠️
...Core/Shape/ShapeStyle/ShapeStyleResolverMode.swift 0.00% 34 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 20 Missing ⚠️
...s/OpenSwiftUICore/View/Image/CGImageProvider.swift 0.00% 16 Missing ⚠️
.../OpenSwiftUICore/View/Image/ImageOrientation.swift 47.36% 10 Missing ⚠️
...ources/OpenSwiftUICore/View/Image/NamedImage.swift 0.00% 8 Missing ⚠️
...UICore/View/Image/ImageAccessibilityProvider.swift 0.00% 6 Missing ⚠️
.../OpenSwiftUICore/Graphic/Color/ConstantColor.swift 0.00% 3 Missing ⚠️
...penSwiftUICore/View/Image/ImageInterpolation.swift 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   28.57%   28.33%   -0.24%     
==========================================
  Files         599      602       +3     
  Lines       36444    36677     +233     
==========================================
- Hits        10414    10394      -20     
- Misses      26030    26283     +253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 2424e15 into main Jan 17, 2026
8 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/resolved_image branch January 17, 2026 13:09
@Kyle-Ye Kyle-Ye linked an issue Jan 17, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Image support

2 participants