Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 17, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: This PR completes the core “Image + View” plumbing and extends the rendering pipeline so Image/Image.Resolved can participate as leaf views with environment-driven styling.

Changes:

  • Implements `Image._makeView` and an `ImageViewChild` rule that resolves images using environment/transaction inputs and supports scraping.
  • Implements large parts of `Image.Resolved`’s leaf-view behavior (layout frame/shape, background shape handling, clear-ness checks, sizing, and `_makeView`).
  • Adds a layout computer/engine (`ResolvedImageLayoutComputer` / `ResolvedImageLayoutEngine`) to support the “images layout as text” semantics path.
  • Introduces cached environment wiring for `foregroundStyle` and `tintColor` via `CachedEnvironment.ID` + `_ViewInputs` accessors.
  • Adds initial scaffolding for symbol effects (`_SymbolEffect`, environment hooks, and `GraphicsImage.updateSymbolEffects`).
  • Refactors a small environment-update path (`LeafLayoutEnvironment.updateValue`) to early-return when unchanged.

Technical Notes: The new image rules use a PropertyList.Tracker to detect relevant environment changes and integrate platform representable contexts for named images and resolved images.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 0% with 286 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.14%. Comparing base (ad4afc5) to head (adc3d72).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ces/OpenSwiftUICore/View/Image/ResolvedImage.swift 0.00% 146 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 114 Missing ⚠️
...esentable/Platform/PlatformViewRepresentable.swift 0.00% 10 Missing ⚠️
Sources/OpenSwiftUICore/Render/SymbolEffect.swift 0.00% 9 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/GraphicsImage.swift 0.00% 3 Missing ⚠️
...SwiftUICore/Shape/ShapeStyle/ForegroundStyle.swift 0.00% 2 Missing ⚠️
Sources/OpenSwiftUICore/Shape/Tint.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   28.35%   28.14%   -0.22%     
==========================================
  Files         602      603       +1     
  Lines       36677    36940     +263     
==========================================
- Hits        10401    10398       -3     
- Misses      26276    26542     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye linked an issue Jan 17, 2026 that may be closed by this pull request
@Kyle-Ye Kyle-Ye merged commit a8fe1e8 into main Jan 17, 2026
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/image_view branch January 17, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Image support

2 participants