feat: support collect Hadoop that turning on https#459
Open
ZhaoQi99 wants to merge 1 commit intoOpenTSDB:masterfrom
ZhaoQi99:master
Open
feat: support collect Hadoop that turning on https#459ZhaoQi99 wants to merge 1 commit intoOpenTSDB:masterfrom ZhaoQi99:master
ZhaoQi99 wants to merge 1 commit intoOpenTSDB:masterfrom
ZhaoQi99:master
Conversation
Member
|
Thank you for contributing! Should we have a configuration file in collectors/etc folder with variables like: |
Author
Yep, I also think so. But there are currently many components (not just Hadoop) here that do not have configuration files. Should we open another PR to do this? |
Member
|
You can just add another commit to this PR with a config usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #458