Skip to content

Conversation

@J-PIE-314
Copy link
Contributor

No description provided.

2TallTyler
2TallTyler previously approved these changes Apr 27, 2025
@auge8472
Copy link
Contributor

auge8472 commented Apr 28, 2025

I would like to make a suggestion for a further simplification. Add the ID openttd-logo-text directly to the image instead of, as now, to the enclosing div.

<a id="openttd-logo" href="{{ site.baseurl }}/">
    <img id="openttd-logo-text" src="{{ site.staticurl }}/img/layout/openttd-logo.png" alt="OpenTTD">
</a>

All CSS rules apply to the ID itself so it is no problem to remove the div that currently "owns" the ID.

Copy link
Contributor

@auge8472 auge8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more clear and simpler now. 👍

@2TallTyler 2TallTyler changed the title Make entire header logo clickable Change: Make entire header logo clickable Apr 28, 2025
@2TallTyler 2TallTyler merged commit 647b121 into OpenTTD:main Apr 28, 2025
7 checks passed
@J-PIE-314 J-PIE-314 deleted the patch-2 branch April 28, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants