Fix UnboundLocalError when no faces are detected#286
Open
Mr-Neutr0n wants to merge 1 commit intoOpenTalker:mainfrom
Open
Fix UnboundLocalError when no faces are detected#286Mr-Neutr0n wants to merge 1 commit intoOpenTalker:mainfrom
Mr-Neutr0n wants to merge 1 commit intoOpenTalker:mainfrom
Conversation
Initialize mask_sharp before the face detection loop to prevent UnboundLocalError when facebs is empty (no faces detected). Previously, mask_sharp was only assigned inside the for loop, so if no faces were detected, line 113 would fail with: "UnboundLocalError: local variable 'mask_sharp' referenced before assignment" Fixes OpenTalker#273
Author
|
following up on this. fixes an UnboundLocalError crash when no faces are detected in a frame — the variable was used before assignment. small fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mask_sharpbefore the face detection loop to preventUnboundLocalErrorwhen no faces are detectedProblem
When processing an image/frame with no detected faces, the code crashes with:
This happens because
mask_sharpis only assigned inside the for loop (line 93), but is used after the loop (line 113). If the loop never executes (no faces detected), the variable is undefined.Solution
Initialize
mask_sharpwith zeros before the loop, matching the dimensions offull_mask.Test plan
Fixes #273