Skip to content

Disable automated link testing #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Disable automated link testing #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b29f51
Disable test broken links on CI
clementbiron Oct 28, 2024
590224e
Remove skipped links
clementbiron Oct 28, 2024
d06b940
Update doc
clementbiron Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,3 @@ jobs:
run: npm run build
- name: Build JSDoc
run: npm run jsdoc
- name: Test broken links
run: npm run test:links
8 changes: 1 addition & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,7 @@ npm run lint:js -- --fix

### Check for broken links

Build the site
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is not required anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's managed by "pretest:links": "npm run build"


```sh
hugo --minify
```

and run
To check for broken links, run the following command:

```sh
npm run test:links
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"build": "hugo --minify",
"test": "npm run lint:markdown && npm run lint:css && npm run lint:js && npm run test:links",
"pretest:links": "npm run build",
"test:links": "linkinator ./public --recurse --skip '^https?://(www.linkedin.com|twitter.com|localhost:3000/api/|stackoverflow.com|github.com/organizations/OpenTermsArchive/settings/personal-access-token-requests|joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12|openai.com|github.com|www.nytimes.com)' --verbosity error",
"test:links": "linkinator ./public --recurse --verbosity error",
"lint:markdown": "markdownlint *.md content/**/*.md",
"lint:css": "stylelint \"themes/opentermsarchive/assets/css/*.css\"",
"lint:js": "eslint themes/opentermsarchive/assets/js/",
Expand Down
Loading