Skip to content

Document logger.timestampPrefix config #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2024
Merged

Document logger.timestampPrefix config #151

merged 2 commits into from
Nov 20, 2024

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Nov 20, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for open-terms-archive-docs ready!

Name Link
🔨 Latest commit ef48699
🔍 Latest deploy log https://app.netlify.com/sites/open-terms-archive-docs/deploys/673dbda3c133170008151a9f
😎 Deploy Preview https://deploy-preview-151--open-terms-archive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ndpnt Ndpnt mentioned this pull request Nov 20, 2024
Merged
@Ndpnt Ndpnt requested a review from MattiSG November 20, 2024 09:15
MattiSG
MattiSG reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sufficient but without a note on the use case, this is not very helpful.

MattiSG
MattiSG approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about adding a paragraph in the style of “used to avoid duplicating timestamps in cases where logs are collected by a process manager”, outside of the JSON example.

@Ndpnt Ndpnt merged commit 03b5a5b into main Nov 20, 2024
5 checks passed
@Ndpnt Ndpnt deleted the update-engine-config-doc branch November 20, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndpnt @MattiSG