Skip to content

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Apr 29, 2025

No description provided.

Copy link

netlify bot commented Apr 29, 2025

Deploy Preview for open-terms-archive-docs ready!

Name Link
🔨 Latest commit dc53468
🔍 Latest deploy log https://app.netlify.com/sites/open-terms-archive-docs/deploys/681b06dd17fab2000819c52a
😎 Deploy Preview https://deploy-preview-172--open-terms-archive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ndpnt Ndpnt force-pushed the improve-deployment-doc branch from 957fb8a to 8033aec Compare April 30, 2025 08:41
@Ndpnt Ndpnt requested review from MattiSG and clementbiron April 30, 2025 09:10
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like really good improvements to me!
I am just a bit concerned with our respect of Diataxis: I wonder if these “how-to guides” don't go a bit too far and integrate reference or explanation elements.

Regarding the “Specific to Open Terms Archive organization members" parts, I feel that the best way to handle them would be to describe these steps in a generic way, such as “back up this key in a secure way as per your organization's procedures”, and we would have our own internal reference in the cloud.

Comment on lines 11 to 24
## Understanding the validation

Open Terms Archive validates terms types to ensure consistency and quality across collections. When you encounter a validation error like:

```shell
1) Service declarations validation
<service_name>
valid declaration schema:
Error:

data/terms must be equal to one of the allowed values (in entire file)
```

This means the terms type you're trying to use isn't in the official list of supported types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section really be in a “how-to” guide? 🤔

data/terms must be equal to one of the allowed values (in entire file)
```

This means the terms type you're trying to use isn't in the official list of supported types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to improve the error message rather than explaining it in documentation?


This means the terms type you're trying to use isn't in the official list of supported types.

## Before going further
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Before going further
## Double-check potential synonyms

Comment on lines 14 to 18
Each collection uses three repositories, `declarations` which contains the terms to track, the engine and deployment configuration, `versions` and `snapshots` which are automatically managed repositories storing versions and snapshots history.

The deployment process is automated through GitHub Actions. Ansible configures the server and sets up the Open Terms Archive engine. On the server, [PM2](https://pm2.keymetrics.io) is used to start and control the engine.

When deployed, the engine runs continuously on the server, periodically checking for changes in the tracked terms. When changes are detected, it automatically commits them to the versions and snapshots repositories. When issues occur, email notifications are sent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudln't this be a reference or an explanation?


- A server with admin access
- All collections repositories created, if not, see the [guide to create repositories]({{< relref "collections/how-to/create-repositories" >}})
- At least one declaration added to your collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- At least one declaration added to your collection
- At least one declaration in your collection (if you created your declaration from the Demo template, one is provided by default)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use the demo template, all declarations are removed by the first time setup process.

Comment on lines 227 to 229
5. > _Specific to Open Terms Archive organization members_
> Create a new SMTP key in Brevo and name it "<collection_name> collection"
> Back up the key in the shared password database by creating an entry titled "SMTP Key" in the collection folder and storing the credentials in this entry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this part obsolete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is used for sending error emails

Improve wording

Co-authored-by: Matti Schneider <[email protected]>
@Ndpnt Ndpnt marked this pull request as ready for review May 6, 2025 07:34
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate an explanation of how the showIfParam works in order so that you can use it easily. It would also be useful for me to know which url parameter I should use, as an Open Terms Archive team member.

We mentioned in sync highlighting the showIfParam sections, so that you can clearly see what is being added to the page. What do you think?

Co-authored-by: Clément Biron <[email protected]>
@Ndpnt Ndpnt merged commit db43488 into main May 7, 2025
5 checks passed
@Ndpnt Ndpnt deleted the improve-deployment-doc branch May 7, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants