Merge pull request #506 from OpenVADL/fix-missing-enoding-crash

ast: Fix crash when undefined symbol is used in encoding

Author: flofriday

vadl/main/vadl/ast/Definition.java

@@ -747,6 +747,10 @@ public FormatDefinition(IdentifierOrPlaceholder identifier, TypeLiteral typeLite
     this.loc = location;
   }
 
+  boolean hasField(String name) {
+    return fields.stream().anyMatch(f -> f.identifier().name.equals(name));
+  }
+
   FormatField getField(String name) {
     return fields.stream().filter(f -> f.identifier().name.equals(name)).findFirst().orElseThrow();
   }

vadl/main/vadl/ast/SymbolTable.java

@@ -1091,7 +1091,7 @@ public Void visit(EncodingDefinition definition) {
 
           // Verify that the field specified really is a field in the encoding
           var field = fieldEncoding.field;
-          if (format.getField(field.name) == null) {
+          if (!format.hasField(field.name)) {
             var suggestions = Levenshtein.suggestions(
                 field.name,
                 format.fields.stream().map(f -> f.identifier().name).toList());

vadl/test/vadl/ast/NameResolutionTest.java

@@ -166,6 +166,24 @@ void registersAvailableInInstruction() {
     Assertions.assertDoesNotThrow(() -> VadlParser.parse(prog), "Cannot parse input");
   }
 
+  @Test
+  void unknownFieldInEcoding() {
+    // https://github.com/OpenVADL/openvadl/issues/478
+    var prog = """
+        instruction set architecture ISA = {
+          register X : Bits<32>
+          format Btype : Bits<32> = {
+            bits [31..0]
+          }
+          instruction BEQ : Btype = { X := 0 }
+          encoding BEQ = { bit = 8 }
+        }
+        """;
+    var error = Assertions.assertThrows(DiagnosticList.class, () -> VadlParser.parse(prog),
+        "Should reject typos");
+    Assertions.assertEquals("Unknown Field: \"bit\"", error.items.getFirst().reason);
+  }
+
   @Test
   void formatFieldsAvailableInInstruction() {
     var prog = """