Open
Conversation
kper
force-pushed
the
feature/replace-docker-builder
branch
4 times, most recently
from
90e7a2f to
6e4f5cf
Compare
kper
force-pushed
the
feature/replace-docker-builder
branch
from
15a87da to
1338214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed many flaky tests, even though, the compiler builds were successful. We concluded that the issue is the legacy docker builder. However, the testcontainer dependency does not support the newer alternative - buildkit. This PR introduces a new dependency that builds the image with buildkit and then runs the image with testcontainers. Because buildkit supports cached layers at build-time, we can drop the redis cache approach.