Feature/add settings resource #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Settings resource in the client while adding a default Content-Type header setting during HTTP requests.
- Added Settings field and initialization in the Client struct
- Added a conditional check in DoRequest to set the Content-Type header if missing
Comments suppressed due to low confidence (1)
cloudconnexa/cloudconnexa.go:47
- Consider adding a comment documenting the purpose of the new Settings field to maintain consistency and improve code readability for new contributors.
Settings *SettingsService
Closed
…d setCommonHeaders helper to centralize Authorization, User-Agent, and Content-Type header logic - Improve maintainability by reducing code duplication across HTTP requests - Preserve existing behavior while enhancing code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #55