Hide password reveal eye icon when no response box is shown#739
Merged
lstipakov merged 1 commit intoOpenVPN:masterfrom Apr 7, 2025
Merged
Hide password reveal eye icon when no response box is shown#739lstipakov merged 1 commit intoOpenVPN:masterfrom
lstipakov merged 1 commit intoOpenVPN:masterfrom
Conversation
When CR_TEXT or dynamic CR prompt is triggered with
'response not required' ('R' not present in flags), we hide the response
box, but not the password reveal eye icon. Fix it.
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Member
|
Indeed single eye icon looks a bit creepy. |
lstipakov
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CR_TEXT or dynamic CR prompt is triggered with 'response not required' ('R' not present in flags), we hide the response box, but not the password reveal eye icon. Fix it.
Avoids this lonely eye:
